Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316502 - makefile outline doesn't work with alternate encoding
Summary: makefile outline doesn't work with alternate encoding
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-editor (show other bugs)
Version: 6.0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Anton Leherbauer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-10 13:55 EDT by Mike Kucera CLA
Modified: 2011-02-24 06:23 EST (History)
0 users

See Also:

Attachments
screeshot (9.53 KB, image/jpeg)
2010-06-10 13:55 EDT, Mike Kucera CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kucera CLA 2010-06-10 13:55:20 EDT 
Created attachment 171657 [details]
screeshot

If I open a makefile that has EBCDIC encoding in the editor, then the outline view is all screwed up (probably also happens with other encodings too).

Steps to reproduce:
* create a makefile
* set its encoding to Cp1047
* open the file in the editor
Comment 1 Anton Leherbauer CLA 2010-06-11 04:00:49 EDT 
The encoding is not considered when the IMakefile model is initially created in

org.eclipse.cdt.make.core.MakeCorePlugin.createMakefile(IFile)

As soon as I start editing, the outline gets fixed because the reconciler uses the editor buffer to update the model.
Comment 2 Anton Leherbauer CLA 2011-02-24 05:25:05 EST 
MakeCorePlugin.createMakefile(IFile) does now respect the IFile encoding.