Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316316 - [memory] Pin Memory Monitor action not working
Summary: [memory] Pin Memory Monitor action not working
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 10:51 EDT by Justin Kong CLA
Modified: 2012-01-23 10:21 EST (History)
2 users (show)

See Also:
Michael_Rennie: review+

Attachments
Proposed Fix (3.20 KB, patch)
2010-06-14 13:51 EDT, Justin Kong CLA 		pawel.1.piech: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Kong CLA 2010-06-09 10:51:01 EDT 
Build Identifier: 

1. Have two Memory views opened with at least one memory monitor added
2. Toggle the Pin Memory Monitor button for one of the Memory views
3. With the other Memory view, add a new memory monitor

Both Memory views will switch to the new memory monitor. The pinned Memory view should not switch from its current memory monitor to the newly added memory monitor.

Reproducible: Always
Comment 1 Justin Kong CLA 2010-06-14 13:51:47 EDT 
Created attachment 171855 [details]
Proposed Fix

MemoryViewTreeModelContentProvider was not using the newest #updateNodes method signature from ModelContentProvider and as a result, its #updateNodes method was never being used. The fix updates the method signature and incorporates the bit mask.


As well, the if statement:
if (getPresentationContext() instanceof MemoryView)

would never return true, as the IPresentationContext is not an instance of MemoryView. Changed the method to reflect this.
Comment 2 Pawel Piech CLA 2012-01-20 01:44:16 EST 
The patch was somewhat out of date, but still correct in principal.  Thank you for the contribution.
Comment 3 Pawel Piech CLA 2012-01-20 01:45:15 EST 
Comment on attachment 171855 [details]
Proposed Fix

I forgot to update the author in the git commit, so I'm setting the iplog flag here.