Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316305 - [Compatibility] turn viewActions into MenuContributions
Summary: [Compatibility] turn viewActions into MenuContributions
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 10:09 EDT by Paul Webster CLA
Modified: 2010-07-05 11:19 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-06-09 10:09:58 EDT 
Currently a view dropdown menu becomes an MRenderedMenu, which does no processing of child model elements and delegates rendering to its MenuManager.

But it will do MenuContribution processing.  If we turn viewActions into a MenuContribution, they might at least show up.

PW
Comment 1 Paul Webster CLA 2010-06-28 13:30:16 EDT 
Large parts of this are done.

PW
Comment 2 Paul Webster CLA 2010-06-28 20:39:49 EDT 
Added separators and toolbar contributions to RenderedToolBarRenderer

PW
Comment 3 Paul Webster CLA 2010-06-29 10:52:07 EDT 
I now add the separators for toolbar groups and menu groups for free, but in their own contributions.  That way they are all added to additions, and then the following contributions that depend on them will show up.

PW
Comment 4 Paul Webster CLA 2010-06-29 11:37:22 EDT 
OK, and now view menus need the correct parent.

PW
Comment 5 Paul Webster CLA 2010-07-05 11:19:54 EDT 
.