Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316295 - EMenuService/MenuContributions - need equivalent for toolbars
Summary: EMenuService/MenuContributions - need equivalent for toolbars
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on: 316802
Blocks: 316299
  Show dependency tree
 
Reported: 2010-06-09 09:50 EDT by Paul Webster CLA
Modified: 2010-06-18 19:09 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-06-09 09:50:42 EDT 
We currently need to fill in the main toolbar, and view toolbars, with contribution from other plugins.

This might be as simple as finding all of the toolbars and applying the parentID/positionInParent logic on startup.

PW
Comment 1 Paul Webster CLA 2010-06-18 12:58:59 EDT 
Remy introducted MToolBarContributions.

How do they work in an e4 app?  When are they applied?

PW
Comment 2 Remy Suen CLA 2010-06-18 19:09:23 EDT 
(In reply to comment #1)
> How do they work in an e4 app?

For a part's toolbar, you'd define an MToolBarContribution with your parentId pointing at a part's id.

For the trim, you'd use a TrimContribution pointing at a given MTrimBar.

> When are they applied?

Assuming the part has a toolbar, the contributions will be applied to the toolbar after the part's object has been instantiated.

Trim contributions will be processed when the trim's widget has been instantiated.

The exact timing of these may need to be reworked because of "timing" requirements for the compatibility layer.