Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316291 - [hotbug] Backport 292943 to wtp 3.0.5Patch
Summary: [hotbug] Backport 292943 to wtp 3.0.5Patch
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: JSF Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Raghunathan Srinivasan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 09:45 EDT by Xiaonan Jiang CLA
Modified: 2010-07-02 00:07 EDT (History)
5 users (show)

See Also:
gerry.kessler: review+


Attachments
Backport Patch (213.31 KB, patch)
2010-06-09 09:48 EDT, Xiaonan Jiang CLA
raghunathan.srinivasan: iplog+
Details | Diff
Updated backport patch (213.33 KB, patch)
2010-06-30 19:51 EDT, Gerry Kessler CLA
no flags Details | Diff
increment service field +1 (1.60 KB, patch)
2010-07-01 20:54 EDT, David Williams CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaonan Jiang CLA 2010-06-09 09:45:48 EDT
Build Identifier: wtp 3.0.5

The fix for bugzilla#292943 greatly reduced the memory footprint. In one of use cases, it can reduce about 300M (around 50%) memory.

We would like this be backported to WTP 3.0.5Patch. 

Reproducible: Always
Comment 1 Xiaonan Jiang CLA 2010-06-09 09:48:29 EDT
Created attachment 171525 [details]
Backport Patch
Comment 2 Yury Kats CLA 2010-06-23 11:04:39 EDT
Can you please comment on whether the patch can be applied?
Comment 3 David Williams CLA 2010-06-23 17:55:54 EDT
Tip: if you just put the word "bug" followed by the bug number, the bugzilla software will create an HTML link directly to it, which I'll do now to illustrate, and provide a link for everyone, and so I won't have to type it in the URL field myself :) 

Such as bug 292943.
Comment 4 Yury Kats CLA 2010-06-30 09:19:07 EDT
Can you please comment on whether the patch can be applied? Our adopter product is rapidly approaching its release date and we really need this patched.

Thanks!
Comment 5 Gerry Kessler CLA 2010-06-30 19:51:05 EDT
Created attachment 173158 [details]
Updated backport patch

This updated patch is very nearly the same as the original patch, except that it fixes an issue that was introduced by the original fix.  I have run the junit tests and done some basic testing, but it could probably use some more.
Comment 6 Yury Kats CLA 2010-07-01 08:14:44 EDT
Thanks for reviewing the patch, Gerry. What's the next step, can the patch be applied now?
Comment 7 David Williams CLA 2010-07-01 11:09:12 EDT
Here's what I think next steps are. 

From what I see, the patch changes 3 modules: 
org.eclipse.jst.jsf.standard.tagsupport
org.eclipse.jst.jsf.common
org.eclipse.jst.jsf.metadata.tests

Two of these already have R3_0_5_patches branches. (so, those branches should be loaded up in your workspace). 

org.eclipse.jst.jsf.standard.tagsupport has not been branched for 305 patches, so it should be. From what I can see in 305 Release map files, the version of this project that was released with WTP 3.0.5 was v20090128, so that version should be loaded in your workspace, and then created a branch from it, named R3_0_5_patches

Apply patch, commit changes, and tag with an ordinary tag, such as 
v201007011300, and report the tags you choose here. (i.e. you don't really 
need to do the "release" step, unless you just want to). 

Report the tags here, and I can do the rest. Which is update org.eclipse.jst.web_core.feature.patch  and I can update the map files with the tags reported. 

But ... I did try applying the patch in my local workspace. The two code ones applied cleanly, but the one for the test bundle did not apply cleanly. Some missing class, or something. And, to be honest, we don't normally fix/build/run unit tests for patch builds, at least on this old stream. So, you can leave it out, as far as I'm concerned, and just tell us what test is likely to fail ... or, you are quite welcome to fix the patch so at least the code in the repo can be corrected ... even if we don't rebuild/run in the actual build. 

Much thanks,
Comment 8 Raghunathan Srinivasan CLA 2010-07-01 19:37:41 EDT
All modified plugins tagged as , v201007011626
Comment 9 David Williams CLA 2010-07-01 20:54:22 EDT
Created attachment 173265 [details]
increment service field +1

Thanks Raghu, but now preparing the features, etc., I realize that ideally the service fields should be incremented by +1. Would you mind incrementing (and/or applying patch) and re-tagging/releasing? 

Thank you
Comment 10 Raghunathan Srinivasan CLA 2010-07-02 00:07:14 EDT
Done. Tag: v201007012100