Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316277 - NPE Ticking / Unticking Fill Paragraphs in History View
Summary: NPE Ticking / Unticking Fill Paragraphs in History View
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.8.1   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Mathias Kinzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 08:29 EDT by James Blackburn CLA
Modified: 2010-06-14 10:16 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2010-06-09 08:29:40 EDT 
I get this NPE if I right click > Tick or Untick "Fill Paragraphs":

java.lang.NullPointerException
at org.eclipse.egit.ui.internal.history.CommitMessageViewer.format(CommitMessageViewer.java:245)
at org.eclipse.egit.ui.internal.history.CommitMessageViewer.setFill(CommitMessageViewer.java:335)
at org.eclipse.egit.ui.internal.history.GitHistoryPage$12.apply(GitHistoryPage.java:741)
at org.eclipse.egit.ui.internal.history.GitHistoryPage$BooleanPrefAction.propertyChange(GitHistoryPage.java:1104)
at org.eclipse.core.runtime.Preferences$1.run(Preferences.java:509)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.runtime.Preferences.firePropertyChangeEvent(Preferences.java:512)
at org.eclipse.core.internal.preferences.legacy.PreferenceForwarder.setValue(PreferenceForwarder.java:239)
at org.eclipse.egit.ui.internal.history.GitHistoryPage$BooleanPrefAction.run(GitHistoryPage.java:1095)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
Comment 1 James Blackburn CLA 2010-06-09 08:31:43 EDT 
In fact I seem to have got the History view into a state where twiddling any of the context menu options gives this exception...

Perhaps related to another exception in the error log:
org.eclipse.swt.SWTException: Widget is disposed
at org.eclipse.swt.SWT.error(SWT.java:4083)
at org.eclipse.swt.SWT.error(SWT.java:3998)
at org.eclipse.swt.SWT.error(SWT.java:3969)
at org.eclipse.swt.widgets.Widget.error(Widget.java:465)
at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:403)
at org.eclipse.swt.custom.SashForm.setMaximizedControl(SashForm.java:359)
at org.eclipse.egit.ui.internal.history.GitHistoryPage.layout(GitHistoryPage.java:627)
at org.eclipse.egit.ui.internal.history.GitHistoryPage.access$21(GitHistoryPage.java:618)
at org.eclipse.egit.ui.internal.history.GitHistoryPage$14.apply(GitHistoryPage.java:761)
at org.eclipse.egit.ui.internal.history.GitHistoryPage$BooleanPrefAction.propertyChange(GitHistoryPage.java:1104)
at org.eclipse.core.runtime.Preferences$1.run(Preferences.java:509)
Comment 2 Mathias Kinzler CLA 2010-06-14 03:02:08 EDT 
Code review at

http://egit.eclipse.org/r/#change,834
Comment 3 Chris Aniszczyk CLA 2010-06-14 10:16:40 EDT 
merged, thanks.