Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316246 - Clean up code should not only run on IPresentationEngine.stop()
Summary: Clean up code should not only run on IPresentationEngine.stop()
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 03:09 EDT by Thomas Schindl CLA
Modified: 2010-06-11 10:04 EDT (History)
3 users (show)

See Also:

Attachments
Fix position to run cleanup code (1.75 KB, patch)
2010-06-10 12:34 EDT, Thomas Schindl CLA 		no flags Details | Diff
patch (1.56 KB, patch)
2010-06-10 12:49 EDT, Thomas Schindl CLA 		no flags Details | Diff
patch (1.79 KB, text/plain)
2010-06-11 08:00 EDT, Thomas Schindl CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-06-09 03:09:39 EDT 
This results in the fact the clean up code in there is not run.
Comment 1 Thomas Schindl CLA 2010-06-10 12:34:02 EDT 
Created attachment 171653 [details]
Fix position to run cleanup code

I think the clean up code is run in the wrong place and should run after the event loop is finished.
Comment 2 Thomas Schindl CLA 2010-06-10 12:49:51 EDT 
Created attachment 171654 [details]
patch
Comment 3 Thomas Schindl CLA 2010-06-10 12:54:35 EDT 
Paul, with the 1st patch I get a test failure but I'm uncertain whether this is a problem with the test.

2nd patch which disposes before closing the window fixes the problem as well. I guess we can go with the 2nd patch because the cleanUp() when called more than once is simply a no-op
Comment 4 Thomas Schindl CLA 2010-06-11 08:00:44 EDT 
Created attachment 171711 [details]
patch
Comment 5 Thomas Schindl CLA 2010-06-11 10:04:26 EDT 
released cleanup change to HEAD