Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316147 - [Memory Browser] should disable the Go To Address, the Go button and the New tab button when the target is not connected
Summary: [Memory Browser] should disable the Go To Address, the Go button and the New ...
Status: RESOLVED WONTFIX
Alias: None
Product: CDT
Classification: Tools
Component: cdt-memory (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Ted Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-08 10:51 EDT by Alain Lee CLA
Modified: 2010-07-27 04:47 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alain Lee CLA 2010-06-08 10:51:44 EDT 
When the target is not connected, users are able to enter an expression and hit the Go button. A traditional rendering is then created and shows all XXXX in the table cells. There is no message indicating that the target is not connected or the data is inaccessible. It would be better if the Go To Address, Go and New Tab button are all disabled until the target is connected.
Comment 1 Alain Lee CLA 2010-06-08 10:59:29 EDT 
I meant the rendering was not showing any data when the target is not connected.
Comment 2 Randy Rohrbach CLA 2010-06-08 14:39:55 EDT 
Alain

   With the many of the changes Teodor added when there is no 
   valid selection the memory Browser now removes the expression
   entry field and the GO/NEW TAB selections.

   Are you sure with the 7.0 release you do not have what you
   want here.

   At least this is the case for my HEAD latest code.

Randy
Comment 3 Alain Lee CLA 2010-06-08 14:47:15 EDT 
(In reply to comment #2)
> Alain
>    With the many of the changes Teodor added when there is no 
>    valid selection the memory Browser now removes the expression
>    entry field and the GO/NEW TAB selections.
>    Are you sure with the 7.0 release you do not have what you
>    want here.
>    At least this is the case for my HEAD latest code.
> Randy

The Expression text box disappears only if the selection is not a valid selection. But, if it is a valid selection but the target is not connected, the express box is still editable and the Go button is enabled.
Comment 4 Teodor Madan CLA 2010-06-09 02:50:39 EDT 
memory browser will switch to unsupported selection when launch is terminated. Can  you check if selected ILaunch is reported as termninated in calls to ILaunch#terminated? At least this works for GDB CDI/DSF backend.
Comment 5 Alain Lee CLA 2010-06-09 13:21:10 EDT 
(In reply to comment #4)
> memory browser will switch to unsupported selection when launch is terminated.
> Can  you check if selected ILaunch is reported as termninated in calls to
> ILaunch#terminated? At least this works for GDB CDI/DSF backend.

This works fine when the debug session is TERMINATED. However, this happended to me when the target was not CONNECTED. In our product, TERMINATE and CONNECT are not the same. We can launch a debug session with a target but the target can be manually connected or disconnected. 

After discussion with our team, we think it is ok to leave the Expression box and the buttons enabled. You can reject this bug.
Comment 6 Teodor Madan CLA 2010-07-27 04:47:35 EDT 
Wontfix. There's no "connected" state info in ILaunch model.