Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316081 - Templates: fix warnings and launch config error
Summary: Templates: fix warnings and launch config error
Status: RESOLVED FIXED
Alias: None
Product: Riena
Classification: RT
Component: Toolbox (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 2.0.0   Edit
Assignee: Christian Campo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 303680 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-07 23:08 EDT by Elias Volanakis CLA
Modified: 2010-07-10 15:03 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Volanakis CLA 2010-06-07 23:08:23 EDT
This patch:

- fixes the warnings in the templates. 
- fixes the missing dependency in the client launch config (from c/s wizard).

I'm applying this to HEAD and 2.0

@Christian: please review
Comment 1 Elias Volanakis CLA 2010-06-07 23:33:27 EDT
Committed

@Christian: it looks to me like the tooling bundles (*templates / *wizard.cs) are not branched ? 

Since I've already commited my changes to head I can't make a patch. The chaged files are below (from cvs console). The changes were minor (removed a few unused imports, added org.apache.oro to one launch config).

***
cvs ci -m "316081 Templates: fix warnings and launch config error" -l "/org.eclipse.riena.ui.templates/src/org/eclipse/riena/ui/templates/hello/HelloRienaTemplate.java" "/org.eclipse.riena.ui.templates/templates_3.4/mail/java/$applicationClass$.java" "/org.eclipse.riena.ui.templates/templates_3.4/helloRiena/java/$applicationClass$.java"
    /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.templates/templates_3.4/mail/java/$applicationClass$.java,v  <--  templates_3.4/mail/java/$applicationClass$.java
    new revision: 1.5; previous revision: 1.4
    /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.templates/src/org/eclipse/riena/ui/templates/hello/HelloRienaTemplate.java,v  <--  src/org/eclipse/riena/ui/templates/hello/HelloRienaTemplate.java
    new revision: 1.10; previous revision: 1.9
    /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.templates/templates_3.4/helloRiena/java/$applicationClass$.java,v  <--  templates_3.4/helloRiena/java/$applicationClass$.java
    new revision: 1.6; previous revision: 1.5
ok (took 0:00.541)
***

***
cvs ci -m "316081 Templates: fix warnings and launch config error" -l "/org.eclipse.riena.ui.wizard.cs/templates/client/console/src/Activator.java" "/org.eclipse.riena.ui.wizard.cs/templates/client/gui/src/applications/CustomersApplication.java" "/org.eclipse.riena.ui.wizard.cs/templates/client/gui/launch-client.xml" "/org.eclipse.riena.ui.wizard.cs/templates/client/gui/src/views/CustomerSearchSubModuleView.java"
    /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.wizard.cs/templates/client/gui/launch-client.xml,v  <--  templates/client/gui/launch-client.xml
    new revision: 1.3; previous revision: 1.2
    /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.wizard.cs/templates/client/console/src/Activator.java,v  <--  templates/client/console/src/Activator.java
    new revision: 1.2; previous revision: 1.1
    /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.wizard.cs/templates/client/gui/src/views/CustomerSearchSubModuleView.java,v  <--  templates/client/gui/src/views/CustomerSearchSubModuleView.java
    new revision: 1.3; previous revision: 1.2
    /cvsroot/rt/org.eclipse.riena/org.eclipse.riena.ui.wizard.cs/templates/client/gui/src/applications/CustomersApplication.java,v  <--  templates/client/gui/src/applications/CustomersApplication.java
    new revision: 1.3; previous revision: 1.2
ok (took 0:00.425)
***
Comment 2 Elias Volanakis CLA 2010-06-07 23:35:43 EDT
*** Bug 303680 has been marked as a duplicate of this bug. ***
Comment 3 Christian Campo CLA 2010-06-08 04:56:11 EDT
first I forgot to branch the toolbox and then I thought that maybe it is not really necessary. So lets continue with just having a HEAD version for tooling for now. So your commit is in, great. I will test it and build a new update site and upload it......
Comment 4 Elias Volanakis CLA 2010-06-28 20:43:57 EDT
@Christian: can we close this?
Comment 5 Elias Volanakis CLA 2010-07-10 15:03:19 EDT
Resolved with 2.0