Community
Participate
Working Groups
Build Identifier: I20100602-1502 The following error is seen when opening Help > Help Contents > JavaServer Faces Tooling User Guide > New and Noteworthy: "An error occured while processing the requested document: org.xml.sax.SAXParseException: The element type "img" must be terminated by the matching end-tag "</img>". at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(Unknown Source) at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(Unknown Source) at org.eclipse.help.internal.dynamic.DocumentReader.read(DocumentReader.java:56) at org.eclipse.help.internal.dynamic.XMLProcessor.process(XMLProcessor.java:49) at org.eclipse.help.internal.xhtml.DynamicXHTMLProcessor.process(DynamicXHTMLProcessor.java:66) at org.eclipse.help.internal.webapp.servlet.DynamicXHTMLFilter$1.close(DynamicXHTMLFilter.java:81) at java.io.FilterOutputStream.close(Unknown Source) at org.eclipse.help.internal.webapp.servlet.FilterHTMLHeadAndBodyOutputStream.close(FilterHTMLHeadAndBodyOutputStream.java:311) at org.eclipse.help.internal.webapp.servlet.PluginsRootResolvingStream.close(PluginsRootResolvingStream.java:220) at java.io.FilterOutputStream.close(Unknown Source) at org.eclipse.help.internal.webapp.servlet.FilterHTMLHeadOutputStream.close(FilterHTMLHeadOutputStream.java:159) at org.eclipse.help.internal.webapp.servlet.EclipseConnector.transfer(EclipseConnector.java:191) at org.eclipse.help.internal.webapp.servlet.ContentServlet.doGet(ContentServlet.java:45) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.eclipse.equinox.http.registry.internal.ServletManager$ServletWrapper.service(ServletManager.java:180) at org.eclipse.equinox.http.servlet.internal.ServletRegistration.service(ServletRegistration.java:61) at org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:126) at org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:68) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:318) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:390) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:924) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)" Reproducible: Always Steps to Reproduce: 1. From the Help menu, select Help Contents 2. Open JavaServer Faces Tooling User Guide > New and Noteworthy
(Also, in the "Getting Started" topics needs to be reordered so that the JSF 2.0 tutorial is listed first, before the JSF 1.2 tutorial)
Also, the "Getting Started" topics in the JSF user guide need reordering so that the JSF 2.0 tutorial is listed first, before the JSF 1.2 tutorial. (corrected typos in earlier comment)
Created attachment 171350 [details] Patch to fix the bug. This patch * Replaces the doctype on whats_new.htm from XHTML 1.0 Transitional to HTML 4.01 Transitional. This fixes the closing tag issues. * Reorders the "Getting Started" list of topics: the JSF 2.0 tutorial comes first now, before the JSF 1.2 tutorial.
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This is a stop-ship issue. The user doc throws an exception when accessing one of the topics. We would also like to address the ordering of topics in the getting started guide to focus on the JSF 2.0 support. * Is there a work-around? If so, why do you believe the work-around is insufficient? No workaround * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Code review. * Give a brief technical overview. Who has reviewed this fix? See comment 3 * What is the risk associated with this fix? none
looks simple, small, doc bundle only. and yes, bad to get an exception. (would be interesting to know how this could happen ... xml/html editor isn't used? ... but, that's a side issue).
I am releasing the change so that it can make it to a build tonight.
I have verified from the latest build (http://build.eclipse.org/webtools/committers/wtp-R3.2.0-S/20100608034029/S-3.2.0RC4-20100608054300/ ) that the fix has been successfully applied.
according to last comment then, this should be 'fixed', and even verified. please correct if I've misunderstood.
I've marked it as Verified/Fixed now.
We have verified the fix. Closing
New Gerrit change created: https://git.eclipse.org/r/114238
Gerrit change https://git.eclipse.org/r/114238 was merged to [master]. Commit: http://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=4a126398b08bc614e867bb432e71cfa52d387ab4
