Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316053 - renaming remote project leads to ProjectNotConfiguredException
Summary: renaming remote project leads to ProjectNotConfiguredException
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.0   Edit
Assignee: Vivian Kong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-07 15:19 EDT by Vivian Kong CLA
Modified: 2019-09-09 16:25 EDT (History)
1 user (show)

See Also:
vivkong: review+
g.watson: review+

Attachments
proposed patch (8.52 KB, patch)
2010-06-07 15:19 EDT, Vivian Kong CLA 		no flags Details | Diff
updated patch (10.36 KB, patch)
2010-06-07 18:35 EDT, Vivian Kong CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivian Kong CLA 2010-06-07 15:19:35 EDT 
Created attachment 171320 [details]
proposed patch

Project names are used as the keys for the service model manager. When the new project name is used to look up services it results in ProjectNotConfiguredExceptions being thrown.  We need a listener for project rename/delete events, so when a project is renamed/deleted the service model can be updated.

Greg, can you please review this patch?  Thanks.
Comment 1 Greg Watson CLA 2010-06-07 16:56:39 EDT 
Looking at this now.
Comment 2 Greg Watson CLA 2010-06-07 17:35:12 EDT 
1. The remap interface needs to be added to IServiceModelManager and documented.

2. The plugin version needs to be incremented to 2.0

3. @since 2.0 tags need to be added to remap and ProjectChangeListener

Otherwise I'm ok with the patch.
Comment 3 Vivian Kong CLA 2010-06-07 17:38:32 EDT 
(In reply to comment #2)
> 1. The remap interface needs to be added to IServiceModelManager and
> documented.
> 
> 2. The plugin version needs to be incremented to 2.0
> 
> 3. @since 2.0 tags need to be added to remap and ProjectChangeListener
> 
> Otherwise I'm ok with the patch.

Thanks Greg!
Comment 4 Vivian Kong CLA 2010-06-07 18:35:36 EDT 
Created attachment 171348 [details]
updated patch
Comment 5 Vivian Kong CLA 2010-06-07 18:39:57 EDT 
Fixed in HEAD.