Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316028 - [publisher] EquinoxExecutableAction should create for macos a symlink to the executable
Summary: [publisher] EquinoxExecutableAction should create for macos a symlink to the ...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal with 3 votes (vote)
Target Milestone: Juno M7   Edit
Assignee: Tobias Oberlies CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331974
  Show dependency tree
 
Reported: 2010-06-07 12:58 EDT by Hugues Malphettes CLA
Modified: 2012-04-19 12:42 EDT (History)
6 users (show)

See Also:


Attachments
One extra line to generate the symbolic link for macosx (6.01 KB, patch)
2010-06-07 12:58 EDT, Hugues Malphettes CLA
no flags Details | Diff
One liner to create the symbolic link to the executable for macosx (1.70 KB, patch)
2010-06-07 13:33 EDT, Hugues Malphettes CLA
t-oberlies: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hugues Malphettes CLA 2010-06-07 12:58:46 EDT
Created attachment 171300 [details]
One extra line to generate the symbolic link for macosx

When EquinoxExecutableAction generates the native touchpoint to setup the executable for maxcosx, it should also generate a symbolic link to the executable.

Symbolic links don't survive a zip. So it has to be generated via the native touchpoint.
Comment 1 Hugues Malphettes CLA 2010-06-07 13:33:53 EDT
Created attachment 171305 [details]
One liner to create the symbolic link to the executable for macosx

Sorry I got confused and attached the wrong patch when I filed the bug.
Comment 2 Pascal Rapicault CLA 2011-05-02 14:23:13 EDT
Tobias, could you please look into releasing this for RC1. Thx.
Comment 3 Tobias Oberlies CLA 2011-05-10 09:56:37 EDT
Unfortunately, I have no way of testing the patch: I can't do a manual test (which would at least require a *nix OS), and I don't know of any integration test chaining up an EquinoxExecutableAction with a director call.
And I don't feel in the position of applying this blindly.

One more minor thing (which is not really an issue): The patch doesn't apply to HEAD because EquinoxExecutableAction moved to /org.eclipse.equinox.p2.publisher.eclipse/src/org/eclipse/equinox/p2/publisher/eclipse/EquinoxExecutableAction.java.
Comment 4 Thomas Watson CLA 2011-06-08 11:29:14 EDT
Move all 3.8 bugs to Juno.
Comment 5 Tobias Oberlies CLA 2012-04-13 05:15:09 EDT
@Hugues: Thank you for the patch. I've applied it to master.

IMHO, the right thing to verify the patch would be an integration test in p2, i.e. a product publisher call followed by an engine call. However AFAIK these kind of tests don't exist yet, and so this would be significantly more effort than the patch itself.

As fallback, I'll be testing the patch in integration in Tycho together with bug 349877 once the change makes it into the next I-build.
Comment 6 Tobias Oberlies CLA 2012-04-19 12:42:10 EDT
(In reply to comment #5)
> As fallback, I'll be testing the patch in integration in Tycho together with bug
> 349877 once the change makes it into the next I-build.
Done.