Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316024 - Performance issue in FlatVirtualComponent for binary references
Summary: Performance issue in FlatVirtualComponent for binary references
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.common (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Jason Peterson CLA
QA Contact: Carl Anderson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-07 12:31 EDT by Jason Peterson CLA
Modified: 2010-06-17 09:53 EDT (History)
3 users (show)

See Also:
cbridgha: review+
ccc: review+

Attachments
patch (1.49 KB, patch)
2010-06-07 12:41 EDT, Jason Peterson CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Peterson CLA 2010-06-07 12:31:00 EDT 
Some profiling was done during publishing and it was discovered that a lot of time was being spent when determining whether a binary reference was a child module.  The reason is due to some duplicate checking going on.  On the first check, the referenced component is used to retrieve the cache when doing the quick peek.  However, then it is checked again, but this time calls quick peek using the path.  This is not cached and takes a while to check.  

The fix is to eliminate the unnecessary check.
Comment 1 Jason Peterson CLA 2010-06-07 12:41:00 EDT 
Created attachment 171299 [details]
patch
Comment 2 Chuck Bridgham CLA 2010-06-14 10:35:05 EDT 
approve
Comment 3 Carl Anderson CLA 2010-06-17 09:42:36 EDT 
I approve.
Comment 4 Carl Anderson CLA 2010-06-17 09:46:19 EDT 
Committed to HEAD for WTP 3.2.1 and WTP 3.3