Community
Participate
Working Groups
Build Identifier: eclipse-SDK-I20100603-1500-win32 When clicking the Restore Defaults button, Eclipse reads the default preferences for remote help, and loads them in. However, when reading the value for the remote help preferred setting, when setting the correct values for the "Include remote help but give local help priority" and "Include remote help but give local help priority", the preference is not negated properly for the local help priority setting. searchLocalHelpFirst.setSelection(new DefaultPreferenceFileHandler().isRemoteHelpPreferred()); searchLocalHelpLast.setSelection(new DefaultPreferenceFileHandler().isRemoteHelpPreferred()); The searchLocalHelpFirst should negate the isRemoteHelpPreferred() value: searchLocalHelpFirst.setSelection(!(new DefaultPreferenceFileHandler().isRemoteHelpPreferred())); The bad behavior is that if remote help preferred is the default, both boxes will have that value which is incorrect. Reproducible: Always Steps to Reproduce: 1. Contribute to the default preferences for remote help 2. Click Restore Defaults 3. Both radios always have the same value
Created attachment 171284 [details] Patch with one line change for correct local help preferred value One line fix: searchLocalHelpFirst.setSelection(!(new DefaultPreferenceFileHandler().isRemoteHelpPreferred()));
Targeting 3.6.1
Created attachment 172463 [details] Improved patch The previous patch was still incorrect - if the default for remoteHelpOn was false setting the defaults would always cause two of the three radio buttons to be set. This new patch works for all four possible combinations of true/false values for remoteHelpOn and remoteHelpPreferred.
Patch applied to 3.6 maintenance stream, Fixed
