Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316008 - Remove org.eclipse.update menu contributions
Summary: Remove org.eclipse.update menu contributions
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 303345
Blocks:
  Show dependency tree
 
Reported: 2010-06-07 11:17 EDT by John Arthorne CLA
Modified: 2010-07-20 19:07 EDT (History)
3 users (show)

See Also:
remy.suen: review+

Attachments
Fix (2.05 KB, patch)
2010-06-07 11:57 EDT, John Arthorne CLA 		no flags Details | Diff
Patch to org.eclipse.ui.ide (1.35 KB, patch)
2010-06-18 12:05 EDT, John Arthorne CLA 		no flags Details | Diff
Cheap fix v01 (1.27 KB, patch)
2010-07-20 18:45 EDT, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2010-06-07 11:17:48 EDT 
The 4.0 SDK doesn't include org.eclipse.update.*, but the top-level menu contributions are still appearing. These should be removed.
Comment 1 John Arthorne CLA 2010-06-07 11:57:41 EDT 
Created attachment 171294 [details]
Fix
Comment 2 John Arthorne CLA 2010-06-07 12:32:26 EDT 
Released.
Comment 3 John Arthorne CLA 2010-06-18 12:04:21 EDT 
This didn't do the trick.
Comment 4 John Arthorne CLA 2010-06-18 12:05:09 EDT 
Created attachment 172229 [details]
Patch to org.eclipse.ui.ide
Comment 5 Paul Webster CLA 2010-07-20 18:45:31 EDT 
Created attachment 174801 [details]
Cheap fix v01

Simply throw away the appropriate menuContribution.

PW
Comment 6 Paul Webster CLA 2010-07-20 18:51:08 EDT 
Boris, is this OK for RC3?

Remy, harmless code?

PW
Comment 7 Boris Bokowski CLA 2010-07-20 18:55:02 EDT 
+1 from me.
Comment 8 Remy Suen CLA 2010-07-20 18:56:30 EDT 
(In reply to comment #6)
> Remy, harmless code?

Looks safe to me.
Comment 9 Paul Webster CLA 2010-07-20 19:07:01 EDT 
Released