Community
Participate
Working Groups
The third party bundles org.mx4j.jmx (dev.eclipse.org:/cvsroot/tptp/monitoring/org.mx4j.jmx) and org.opengroup.arm (dev.eclipse.org:/cvsroot/tptp/trace/org.opengroup.arm) had their plug-in Manifest.mf version number updated when maintenance was performed on the plug-ins. The third party jars and version did not change so the plug-in version should be updated to match the third party version. The qualifier update could be used to indicate a change in the packaging (e.g. Bundle-RequiredExecutionEnvironment, Bundle-Vendor, etc.) similar to what is done in Orbit. As indicated in their corresponding about.html files to match the third party version: org.mx4j.jmx should change the packaging version number to 3.0.1 from 3.1.0 org.opengroup.arm should change the packaging version number to 4.0.0 from 4.1.0
Created attachment 171280 [details] Modifies version number for org.opengroup.arm
Created attachment 171281 [details] Modifies version number for org.mx4j.jmx
Sean, Can you please review? Thanks!
Patches look good!
I would like to request PMC approval to include the following fix in TPTP 4.7.0. 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Modifies the org.mx4j.jmx and org.opengroup.arm plug-in version to match the third party bundle version. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No. 4. Does this require new API? No. 5. Who performed the code review? Sean 6. Is there a test case attached to the bugzilla record? n/a 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? A fresh install will cleanly pick up this version of the third party bundles. Updating an existing installation would not pick up this version of the As-Is monitoring components due to the plug-in version increase. Depending on the previously installed version, packaging or plug-in modifications (such as Bundle Vendor, Execution Environment, TPTP feature image) would not be applied, however, the version of the installed third party jar would be the same. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? n/a
This change is required to have the version of the plugin matching that in the 3rd party JAR and what's been approved in the CQ (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=306 and https://dev.eclipse.org/ipzilla/show_bug.cgi?id=307). Requesting approval for TPTP 4.7.
Patch for ARM checked into HEAD.
Patch for MX4J was checked into HEAD.
Created attachment 171468 [details] Patch for including jars Patch to include third party jars in output.
Patch looks good. It might be possible to remove the copyright to be consistent with what was packaged previously.
Patch checked into HEAD.
Verified on TPTP-4.7.0RC4-201006081927.
