Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315948 - SWT doesnt work on WinCE 6.0 since v3312. Missing check on OS.IsWinCE
Summary: SWT doesnt work on WinCE 6.0 since v3312. Missing check on OS.IsWinCE
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.0   Edit
Hardware: Other other
: P3 normal (vote)
Target Milestone: 3.6.1   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-07 06:26 EDT by Nils Israel CLA
Modified: 2010-07-29 09:12 EDT (History)
2 users (show)

See Also:
Silenio_Quarti: review+

Attachments
patch (886 bytes, patch)
2010-07-28 10:47 EDT, Felipe Heidrich CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nils Israel CLA 2010-06-07 06:26:01 EDT 
Build Identifier: 

SWT doesnt work on WinCE because of commit 1.298 in org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/OS.java

/* Make the process DPI aware for Windows Vista */
if (OS.WIN32_VERSION >= OS.VERSION (6, 0)) OS.SetProcessDPIAware ();

should be replaced by

/* Make the process DPI aware for Windows Vista */
if (!OS.IsWinCE && OS.WIN32_VERSION >= OS.VERSION (6, 0)) OS.SetProcessDPIAware ();



Reproducible: Always

Steps to Reproduce:
1. start an SWT App on WinCE 6.0
Comment 1 Felipe Heidrich CLA 2010-06-07 09:49:49 EDT 
I see, the code has being wrong for a long time, we never saw the problem because we don't have wince 6.0.

It is too late to fix this problem for 3.6.
We will have it fixed first thing for 3.6.1.
Sorry
Comment 2 Felipe Heidrich CLA 2010-07-28 10:47:51 EDT 
Created attachment 175413 [details]
patch
Comment 3 Felipe Heidrich CLA 2010-07-28 10:48:41 EDT 
Fixed in HEAD > 20100728


Silenio, 3.6.1 ?
Comment 4 Silenio Quarti CLA 2010-07-28 11:20:30 EDT 
Sure.
Comment 5 Felipe Heidrich CLA 2010-07-29 09:12:03 EDT 
Fixed in 3.6.maintenance > 20100729