Community
Participate
Working Groups
The attachment details dialog does not follow all UI guidelines which should be easy to fix: * The dialog needs a title. * The page title should say "Attachment Details" * The page descriptions should say "Modify attachment XYZ on bug ZYX." * Move the obsolete checkbox on the same line as filename? * The URL field should move above Advanced. * The Advanced section should not be indented. * The dialog should not be repacked when toggling Advanced. * Borders for the flag input fields should not be form borders but use the standard platform style. * The comment field should fill when making the dialog taller
Created attachment 171228 [details] screenshot
Fixed the dialog title.
Created attachment 171230 [details] mylyn/context/zip
Should I do the other points?
If you are up for it, please feel free to start hacking on this. Since it's only nits we should wait with committing this until the release is out.
Created attachment 172361 [details] screenshot of new UI We use SashForm so you can resize the two parts sash with is 10 pixel. Thougths?
I am not sure if we need to make that resizable. Do we get a benefit for the extra complexity?
(In reply to comment #7) > I am not sure if we need to make that resizable. Do we get a benefit for the > extra complexity? Actual we use SashForm so it is no extra complexity. One part is for the ScrolledComposite (with the Advanced Section) the other for the Comment. I think it is better to make clear that you can change the Weights from 75 / 25 to a value that better fit the number of flags that are defined (if visible).
I am mostly worried about the extra complexity for users since there would be two components to resize, the dialog and the comment area. Is is not possible to make the comment area grab all excess space?
(In reply to comment #9) > I am mostly worried about the extra complexity for users since there would be > two components to resize, the dialog and the comment area. Is is not possible > to make the comment area grab all excess space? Yes we can do this but what is if we have many flags and there is no space left? Thoughts?
Wou(In reply to comment #10) > (In reply to comment #9) > > I am mostly worried about the extra complexity for users since there would be > > two components to resize, the dialog and the comment area. Is is not possible > > to make the comment area grab all excess space? > > Yes we can do this but what is if we have many flags and there is no space left? Wouldn't the flags still be in a nested scrollable?
(In reply to comment #11) > Wou(In reply to comment #10) > > (In reply to comment #9) > > > I am mostly worried about the extra complexity for users since there would be > > > two components to resize, the dialog and the comment area. Is is not possible > > > to make the comment area grab all excess space? > > > > Yes we can do this but what is if we have many flags and there is no space left? > > Wouldn't the flags still be in a nested scrollable? Yes, the aew under the Advanced Expandable.
Created attachment 175179 [details] patch This patch contains all points from the Description. This Dialog now use a separate section for every repository. So you can set the state of the advanced and change the size of the comment box.
Created attachment 175180 [details] mylyn/context/zip
Created attachment 175182 [details] new UI screenshot
The scroll movable sash adds too much UI complexity for too little benefit. We should get rid of that and have the Comment section grab the space that's needed.
Agreed, it would best if this worked similar to the attach file dialog.
Thanks for doing these changes, Frank. Let's look at wrapping this up together for 3.4.2.
Created attachment 176110 [details] patch V2 comment#16 and comment#17 stuff is included. We can use this for the backport.
Created attachment 176111 [details] mylyn/context/zip
(In reply to comment #19) > Created an attachment (id=176110) > patch V2 > > comment#16 and comment#17 stuff is included. > > We can use this for the backport. Commit to HEAD.
Created attachment 178011 [details] screen shot
Created attachment 178012 [details] backported patch
I have committed the back ported patch to the e_3_6_m_3_4_x branch. Frank, could you take a look if the changes look sane to you? I have opened bug 324263 to fix the problem with the native borders. I don't think there is a way to make that work properly with the current attribute editor framework.
(In reply to comment #24) > I have committed the back ported patch to the e_3_6_m_3_4_x branch. Frank, > could you take a look if the changes look sane to you? > Yes the back ported patch is OK so I close this bug.
Further suggestions from today's meeting: * Make label of advanced section bold * Look into redraw problem when expanding section
Created attachment 178222 [details] patch V4 Requests from Comment#26 are now included.
Created attachment 178223 [details] mylyn/context/zip
Hope that we are done now.
Patch v4 was also applied to the e_3_4_m_3_x branch.
Shawn verified that the redraw problem is now fixed on Windows. Thanks for your patience, Frank!
