Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315914 - "Add Element" popup should only show the elements allowed at the current cursor position
Summary: "Add Element" popup should only show the elements allowed at the current curs...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Florian Thienel CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-06 18:37 EDT by Florian Thienel CLA
Modified: 2011-11-09 17:37 EST (History)
0 users

See Also:

Attachments
Prototype (without tests) (1.56 KB, patch)
2010-06-07 18:27 EDT, Holger Voormann CLA 		no flags Details | Diff
mylyn/context/zip (1.54 KB, application/octet-stream)
2010-06-17 17:55 EDT, Florian Thienel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Thienel CLA 2010-06-06 18:37:54 EDT 
Is:
The current implementation of the  "Add Element" popup shows a lot more elements than allowed at the current cursor position.

Should:
Only the elements that are allowed at the current cursor position should be shown in the popup.
Comment 1 Holger Voormann CLA 2010-06-07 18:27:04 EDT 
Created attachment 171346 [details]
Prototype (without tests)

The same is true for "Convert Element" popup.

Maybe this could be done in VexWidgetImpl.getValidInsertElements() (see attachment) and  getValidMorphElements().
Comment 2 Florian Thienel CLA 2010-06-17 16:56:26 EDT 
The patch looks fine. I'll see how to test this.
Comment 3 Florian Thienel CLA 2010-06-17 17:55:20 EDT 
I applied your patch and added a test for it.
Comment 4 Florian Thienel CLA 2010-06-17 17:55:22 EDT 
Created attachment 172165 [details]
mylyn/context/zip
Comment 5 Florian Thienel CLA 2011-06-02 05:25:52 EDT 
Closing resolved bugs.
Comment 6 Florian Thienel CLA 2011-11-09 17:37:54 EST 
Moved to Mylyn Docs Vex.