Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315910 - assembly feature being included in repo
Summary: assembly feature being included in repo
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 2.3   Edit
Hardware: PC Windows 7
: P1 normal (vote)
Target Milestone: 2.3 RC4   Edit
Assignee: Tran Le CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-06 14:52 EDT by David Williams CLA
Modified: 2010-06-07 17:06 EDT (History)
1 user (show)

See Also:
david_williams: pmc_approved+
neil.hauge: pmc_approved? (raghunathan.srinivasan)
neil.hauge: pmc_approved? (naci.dai)
deboer: pmc_approved+
tranle1: pmc_approved?
neil.hauge: pmc_approved? (kaloyan)
neil.hauge: review+

Attachments
proposed patch (3.67 KB, patch)
2010-06-07 11:34 EDT, Tran Le CLA 		no flags Details | Diff
proposed patch 2 (2.88 KB, patch)
2010-06-07 11:59 EDT, Tran Le CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2010-06-06 14:52:54 EDT 
I've just noticed that 
org.eclipse.jpt_sdk.assembly.feature 
is being included in our wtp repo, as an IU (i.e. could be installed). 

This isn't right. If someone did install it, it might mean they'd later end up with an invalid installation that could not be upgraded, or integrated with other packages. 

easy enough to fix, the build.properties just needs to be empty. 

(There may be other places we explicitly exclude features with the word "assembly" in their name ... but,  I did that before knowing you could have features which were not packaged (by having empty build.properties).
Comment 1 David Williams CLA 2010-06-06 14:54:35 EDT 
I've taken the liberty of marking as 'P1' since

I personally think should be fixed for our final build/repo, since "repos are forever" and it is hard, if not impossible, to remove features in subsequent service releases. 

I'll check if there are others.
Comment 2 David Williams CLA 2010-06-06 14:56:18 EDT 
Yep, org.eclipse.jpt.tests.assembly.feature 
is also there. Only these from Dali are being included. 
Sorry I didn't catch earlier and/or pass along this info about empty build.properties files for assembly features.
Comment 3 David Williams CLA 2010-06-07 03:21:47 EDT 
Hm, worse than I thought. All our assembly features are showing up in repos, using a "pure" P2 build. I think due to some recent changes in PDE build, instead of an empty build.properties, it needs to have an explicit, empty 

bin.includes=

This it us in Orbit, also. 
I'm testing that now on a local build.
Comment 4 Tran Le CLA 2010-06-07 11:34:48 EDT 
Created attachment 171287 [details]
proposed patch
Comment 5 David Williams CLA 2010-06-07 11:48:16 EDT 
Well, sounds like it should be completely empty, after all. 

I think there's still a bug/change in behavior that will require some "post build" tweaking to remove some of our assembly features. 

I've documented the general bug/issue in PDE bug 310674

And will document our workaround of the general issue in our "p2izing" bug 315919

(But, these build.properties should be empty in any case, even if we were not doing the P2izing. 

Thanks,
Comment 6 Tran Le CLA 2010-06-07 11:59:20 EDT 
Created attachment 171295 [details]
proposed patch 2
Comment 7 Neil Hauge CLA 2010-06-07 13:29:48 EDT 
Requesting PMC review for this change to make our assembly features consistent with others in WTP.  Should be no real risk with this change.
Comment 8 Tran Le CLA 2010-06-07 17:06:16 EDT 
Checked in and released