Community
Participate
Working Groups
If a copy Valgrind is not present in the user's PATH, the code that checks the preference page for a manually set location is never executed. This defeats most of the purpose of having the preference.
I have committed a fix that moves the preference checking ahead of calling the which command. The which command is now only used if the preference is not set manually. The preference checking itself is moved to the ValgrindCommand class. Now what happens is when the plugin first needs to access the location of the Valgrind binary, it calls ValgrindCommand.whichValgrind(). This checks for the path set in a preference. If a path is not set, it calls the which command. The resulting path from either the preference store or the which command is cached for subsequent accesses. To force an update when the user changes the preference page, the ValgrindLaunchPlugin registers itself as a listener on that preference and invalidates the cached location when this preference is changed. As Andrew mentioned for commits this close to Helios: ** All commits over the next 5 days must have an associated bug ** This bug is noted in the Changelogs. ** All commits over the next 5 days should be reviewed by at least one other committer ** Roland, would you be able to review the changes? You would be the ideal candidate since you implemented the preference page. ** All commits over the next 5 days should have a test case to verify that they do indeed fix what they intend to ** LocationPreferenceTest tests this bug specifically. It fails before the changes and succeeds after.
Reproduced bug, and have confirmed that it is fixed in trunk.
