Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315887 - API usage issue in EventDispatcher3D
Summary: API usage issue in EventDispatcher3D
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Gef3d (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Jens Von Pilgrim CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-05 15:19 EDT by Miles Parker CLA
Modified: 2021-03-23 18:16 EDT (History)
1 user (show)

See Also:


Attachments
Patch to fix method visibility issue (21.77 KB, application/octet-stream)
2010-06-05 15:19 EDT, Miles Parker CLA
no flags Details
mylyn/context/zip (872 bytes, application/octet-stream)
2010-06-06 06:28 EDT, Jens Von Pilgrim CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2010-06-05 15:19:25 EDT
Created attachment 171204 [details]
Patch to fix method visibility issue

It looks like there is an incompatibility in API either in GEF3D or instroduced through GEF 3.6. getFocusOwner needs to be public. (Patch included.) Marking as major just because it won't build on my Helios based setup.
Comment 1 Jens Von Pilgrim CLA 2010-06-05 18:26:52 EDT
Miles, thanks for the patch. Actually, I'm already aware of this problem, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=306609 . I haven't submitted the GEF 3.6 related code yet, as Helios is not final yet. I will submit the code as soon as Helios is final. The problem is, that then  GEF3D won't compile with GEF 3.5 and elder versions. Also, there seem to be some more problems with GEF 3.6, I have already submitted some fixes, but I haven't had the time to track them all down.
Comment 2 Miles Parker CLA 2010-06-05 19:14:38 EDT
Ah -- ok gotcha. That's true even if yo take out the override? Kind of too bad because other than that there is no reason that you can't use GEF3D with 2.5.
Comment 3 Jens Von Pilgrim CLA 2010-06-06 04:27:37 EDT
With GEF 3.6, the EventDispatcher3D could be moved into package o.e.draw3d -- which is nicer of course :-) But yes, it is the very only thing that breaks compatibility with GEF 3.5 (and less). The only solution I can think of is to create two plugin fragments, one for GEF3 3.6 and one of predecessor versions. However, these fragments would contains one class only.
Comment 4 Jens Von Pilgrim CLA 2010-06-06 06:28:09 EDT
Miles, I have committed a version of EventDispatcher3D that should work with GEF 3.5 and GEF 3.6. Looks as if it is quite similar to your patched version. It is the version I'm working with for quite some time, I simply didn't dare to commit it...). Please re-open this bug if the new version doesn't work for you.
Comment 5 Jens Von Pilgrim CLA 2010-06-06 06:28:12 EDT
Created attachment 171215 [details]
mylyn/context/zip