Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315886 - Unnecessary dependency on emf transaction.
Summary: Unnecessary dependency on emf transaction.
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Gef3d (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jens Von Pilgrim CLA
QA Contact: Jens Von Pilgrim CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-05 15:13 EDT by Miles Parker CLA
Modified: 2021-03-23 18:16 EDT (History)
1 user (show)

See Also:

Attachments
Patch for fix. (629 bytes, application/octet-stream)
2010-06-05 15:13 EDT, Miles Parker CLA 		no flags Details
mylyn/context/zip (15.95 KB, application/octet-stream)
2010-06-06 06:02 EDT, Jens Von Pilgrim CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2010-06-05 15:13:37 EDT 
o.e.gef.ext has an (apprarantly) unneeded dependency on emf.transaction. I've replaced it with o.e.ecore and o.e.ecore.edit in this patch.
Comment 1 Miles Parker CLA 2010-06-05 15:13:58 EDT 
Created attachment 171203 [details]
Patch for fix.
Comment 2 Jens Von Pilgrim CLA 2010-06-06 06:02:25 EDT 
Fixed by extracting all EMF related classes to a new plugin called org.eclipse.gef3d.ext.emf. The EMF related classes were moved to sub-packages *.emf. The ext plugin should be independent from EMF, since important features such as assimilators should be available w/o requiring EMF.

Plugin org.eclipse.gef3d.gmf re-exports the newly created plugin for convenience. 

The ecore and uml examples were adjusted accordingly, in order to adust your own code (in case of compile errors), you will have to:
- import org.eclipse.gef3d.ext.multieditor.emf for INestableEditorWithEditingDomain/ResourceSet
- in case your plugin does not require  org.eclipse.gef3d.gmf, you will have to add  org.eclipse.gef3d.ext.emf
Comment 3 Jens Von Pilgrim CLA 2010-06-06 06:02:29 EDT 
Created attachment 171214 [details]
mylyn/context/zip