Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315877 - [Discovery] Zookeeper and localfile do not include discovery feature
Summary: [Discovery] Zookeeper and localfile do not include discovery feature
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.discovery (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-05 10:39 EDT by Wim Jongman CLA
Modified: 2010-06-06 05:28 EDT (History)
2 users (show)

See Also:

Attachments
P2 Update screen (84.90 KB, image/png)
2010-06-05 10:48 EDT, Wim Jongman CLA 		no flags Details
patch (2.09 KB, patch)
2010-06-05 10:58 EDT, Wim Jongman CLA 		no flags Details | Diff
mylyn/context/zip (894 bytes, application/octet-stream)
2010-06-05 17:13 EDT, Wim Jongman CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2010-06-05 10:39:52 EDT 
zeroconf includes the base discovery feature. zookeeper and localfile do not. Need they be included?
Comment 1 Wim Jongman CLA 2010-06-05 10:48:32 EDT 
Created attachment 171196 [details]
P2 Update screen
Comment 2 Wim Jongman CLA 2010-06-05 10:58:38 EDT 
Created attachment 171197 [details]
patch

I thought I patched that b.a. I didn't. Need to include feature o.e.d.feature. Can I get an ok for this patch before rc4?
Comment 3 Scott Lewis CLA 2010-06-05 12:11:11 EDT 
+1 for this change.  Wim please let all know here on this bug whether you release the change to HEAD or you wish me to do so.  Thanks.
Comment 4 Wim Jongman CLA 2010-06-05 17:13:29 EDT 
released to HEAD
Comment 5 Wim Jongman CLA 2010-06-05 17:13:31 EDT 
Created attachment 171207 [details]
mylyn/context/zip
Comment 6 Wim Jongman CLA 2010-06-05 17:15:03 EDT 
and FIXED
Comment 7 Markus Kuppe CLA 2010-06-06 05:28:28 EDT 
IMO all discovery feature may use require instead of include. E.g. include causes the build to rebuild "o.e.e.discovery.feature" rather than consume it while there is no advantage of using include over require with p2.

We should wait with this change for after Helios though.