Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315827 - Found a JpaProject leak in the JpaDetailsView
Summary: Found a JpaProject leak in the JpaDetailsView
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 2.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.3.1   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 15:43 EDT by Karen Butzke CLA
Modified: 2010-07-23 15:31 EDT (History)
1 user (show)

See Also:
neil.hauge: review+


Attachments
proposed patch against head (1.99 KB, patch)
2010-06-17 18:00 EDT, Karen Butzke CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2010-06-04 15:43:31 EDT
1. Open 1 Java Entity in the editor and view it in the Jpa Details view.
2. Close the Java editor.
3. Close the Project.  

The cached PersistentTypeDetailsPage in JpaDetailsView still contains the PerssitentType subject, thus the JpaProject is still hanging around.

The issue is that the PersistentTypeDetailsPage subject is not set to null when the editor is closed.

I tested this in debug by putting a breakpoint in JpaDetailsView.dispose and after step 3 I closed the JpaDetailsView and dug into the cache of details pages. Was also able to see the GenericJavaPersistentType2_0 object hanging around referenced by the PersistentTypeDetailsPage using the sun JDK leak tools that Brian mentioned recently.
Comment 1 Karen Butzke CLA 2010-06-17 18:00:13 EDT
Created attachment 172166 [details]
proposed patch against head
Comment 2 Karen Butzke CLA 2010-06-24 14:48:42 EDT
resolved in HEAD for 2.3.1 maintenance
Comment 3 Karen Butzke CLA 2010-07-23 15:31:46 EDT
manually verified this in debug as described in the bug description