Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315793 - AFE when changing a bugzilla bug
Summary: AFE when changing a bugzilla bug
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P1 critical (vote)
Target Milestone: 3.4   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 11:43 EDT by Shawn Minto CLA
Modified: 2010-06-04 13:35 EDT (History)
1 user (show)

See Also:


Attachments
patch (6.70 KB, patch)
2010-06-04 12:37 EDT, Frank Becker CLA
eclipse: review?
Details | Diff
mylyn/context/zip (10.39 KB, application/octet-stream)
2010-06-04 12:37 EDT, Frank Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2010-06-04 11:43:17 EDT
What steps will reproduce the problem?
1. create a new bug
2. submit the bug
3. make a change to the bug
4. try to submit the bug


-- Error Details --
Date: Fri Jun 04 08:39:12 PDT 2010
Message: Unhandled event loop exception
Severity: Error
Product: Eclipse SDK 3.6.0.v201005271700 (org.eclipse.sdk.ide)
Plugin: org.eclipse.ui
Session Data:
eclipse.buildId=I20100527-1700
java.version=1.6.0_20
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Framework arguments:  -product org.eclipse.sdk.ide -keyring C:\Eclipse\bootstrap.keyring
Command-line arguments:  -product org.eclipse.sdk.ide -data C:\workspaces\MYLYN-3.1-DEV-workspace/../3.1-bootstrap-mylyn-old -dev file:C:/workspaces/MYLYN-3.1-DEV-workspace/.metadata/.plugins/org.eclipse.pde.core/BOOTSTRAP/dev.properties -os win32 -ws win32 -arch x86 -keyring C:\Eclipse\bootstrap.keyring


Exception Stack Trace:
org.eclipse.core.runtime.AssertionFailedException: null argument:
at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)
at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)
at org.eclipse.mylyn.tasks.core.data.TaskAttribute.setValue(TaskAttribute.java:531)
at org.eclipse.mylyn.internal.bugzilla.ui.editor.BugzillaTaskEditorPage.doSubmit(BugzillaTaskEditorPage.java:262)
at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage$20$1.handleEvent(AbstractTaskEditorPage.java:1063)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
at org.eclipse.equinox.launcher.Main.main(Main.java:1383)
Comment 1 Frank Becker CLA 2010-06-04 12:37:32 EDT
Created attachment 171122 [details]
patch

I can not reproduce this.

But the problem is triggered is doSubmit when the Attribute from getTask is null. 
So I add an test and only set the tokenvalue if it is not null.

Rob,

can you please verify!
Comment 2 Frank Becker CLA 2010-06-04 12:37:35 EDT
Created attachment 171123 [details]
mylyn/context/zip
Comment 3 Shawn Minto CLA 2010-06-04 12:48:56 EDT
Frank, this looks like the right fix to me.  I haven't seen this before either and can't seem to reproduce again here, but it would be good to guard against this.
Comment 4 Robert Elves CLA 2010-06-04 13:25:19 EDT
Looks right to me Frank. +1
Comment 5 Frank Becker CLA 2010-06-04 13:34:11 EDT
(In reply to comment #3)
> Frank, this looks like the right fix to me.  I haven't seen this before either
> and can't seem to reproduce again here, but it would be good to guard against
> this.
(In reply to comment #4)
> Looks right to me Frank. +1
OK then I commit this to HEAD.
Comment 6 Frank Becker CLA 2010-06-04 13:35:10 EDT
Pacht is now in HEAD.