Community
Participate
Working Groups
Build Identifier: Target against Helios update site When the org.eclipse.equinox.p2.publisher.AbstractPublisherApplication processes the command line parameter -contextMetadata it uses the member "agent". However this member is still null at that point in time. Consequently the context metadata repository of the PublisherInfo is set to null (meaning no context repository). Effectively the parameter -contextMetadata is ignored. Reproducible: Always Steps to Reproduce: The parameter "-contextMetadata" is interpreted here: at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.processMetadataRepositoryList(AbstractPublisherApplication.java:213) at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.processParameter(AbstractPublisherApplication.java:183) at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.processCommandLineArguments(AbstractPublisherApplication.java:149) at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.run(AbstractPublisherApplication.java:270) at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.start(AbstractPublisherApplication.java:323) ... but the member "agent" is only initialized afterwards: at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.setupAgent(AbstractPublisherApplication.java:252) at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.run(AbstractPublisherApplication.java:292) at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.run(AbstractPublisherApplication.java:271) at org.eclipse.equinox.p2.publisher.AbstractPublisherApplication.start(AbstractPublisherApplication.java:323)
Created attachment 171839 [details] delay initialization of context repositories Hi, with this patch the context repositories do not get initialized during parameter processing (with agent == null). Instead the already existing logic in initializeRepositories() will do the job. Could we have the patch applied before the final release? I think the bug is rather severe and the patch is rather trivial. Kind regards, Jan
We talked about this on the p2 call today and it seems a late for 3.6.0. I've marked this 3.6.1 and I will it there (and in 3.7). I've CC'd Pascal in case he feels differently (he wasn't on the call today).
I'll stick for 3.6.1 and get it in the build asap so work depending on this can actually proceed.
Created attachment 177364 [details] Patch with test case I really like the patch, thanks! I first thought we should just init the agent earlier, but your patch demonstrates that we actually have two different code paths for setting the context repo. You're patch reduces this so that the ant tasks and the applications now use the same path. I like that. My patch just adds two tests cases which makes it easier to see this problem.
I've talked to pascal on IRC and he gave the go-ahead for this patch. Pascal, do you want to give the review the +1.
I've given Jan's patch the IPLog+, since it's the one used in the end (I just added the test case).
Ian, I thought I saw these changes released into the 3.6.1 when I sync'd up this morning. Can this bug be closed now? (just going through our 3.6.1 and trying to get resolution on them)
This patch was released into 3.6.1.
