Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315738 - DiffEpatchService handles MoveModelElement incorrectly
Summary: DiffEpatchService handles MoveModelElement incorrectly
Status: CLOSED WONTFIX
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: 1.1   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 04:48 EDT by Steffen Dienst CLA
Modified: 2011-06-15 10:23 EDT (History)
1 user (show)

See Also:

Attachments
JUnit 4 test case (4.32 KB, application/zip)
2010-06-04 04:48 EDT, Steffen Dienst CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Dienst CLA 2010-06-04 04:48:20 EDT 
Created attachment 171074 [details]
JUnit 4 test case

The creation of an EPatch fails, if a model element got moved between two differing EStructuralFeatures. The attached testcase contains a simple example: An element gets moved between two different containers. 

The MatchModel recognizes this move and DiffEpatchService#handleEleMove(MoveModelElement ele) gets called.
This method tries to remove/add the element on either side, but uses a single EStructuralFeature for each. This fails in my case, as the containing feature is different.

A solution seems to be to use both containing features for adding/removing the element? Sadly, my understanding of the inner workings of the DiffEpatchService is not up to par...
Comment 1 Laurent Goubet CLA 2011-06-15 10:23:34 EDT 
EPatch has been deprecated in favor of MPatch as the commiter in charge of EPatch has dropped down working on EMF Compare. Consequently, this bug won't be fixed.