Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315668 - Creating Java project loads JptCorePlugin
Summary: Creating Java project loads JptCorePlugin
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 2.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.3.1   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 16:25 EDT by Karen Butzke CLA
Modified: 2010-07-20 09:02 EDT (History)
1 user (show)

See Also:
neil.hauge: review+

Attachments
proposed patch against head (6.26 KB, patch)
2010-06-17 17:37 EDT, Karen Butzke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2010-06-03 16:25:38 EDT 
Creating a Java project is loading org.eclipse.jpt.core.JptCorePlugin unnecessarily.  Our contentType extensions are causing this. We need to go ahead and associate our contentTypes with the xml file extension even though we extend the org.eclipse.core.runtime.xml contentType which sets the file extension as xml. It sort of looks like a bug in the ContentType functionality, but also appears they did this on purpose.

Every example I see on the web of defining an xml content type extends the org.eclipse.core.runtime.xml ContentType and redefines the file extension.
Comment 1 Karen Butzke CLA 2010-06-03 17:29:36 EDT 
we should look at bug 285370 for another way to handle this. Otherwise we are just delaying our bundle activation until there is a .xml file in the project. This happens when a project is changed to a faceted project.

Our org.eclipse.jpt.core.internal.resource.IndeterminateContentDescriber is what is being loaded.
Comment 2 Karen Butzke CLA 2010-06-17 17:37:58 EDT 
Created attachment 172164 [details]
proposed patch against head

this patch just moves the IndeterminateContentDescriber to a new package org.eclipse.jpt.core.internal.resource.contenttypes and excludes that package from bundle activation
Comment 3 Karen Butzke CLA 2010-06-17 17:42:37 EDT 
Neil, I assume this type of change is fine to make in maintenance, but wanted to run it by you. Patch is attached
Comment 4 Karen Butzke CLA 2010-06-24 14:52:00 EDT 
resolved in HEAD for 2.3.1 maintenance
Comment 5 Karen Butzke CLA 2010-07-20 09:02:33 EDT 
verified fixed in build wtp-sdk-M-3.2.1-20100716070539