Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315628 - org.eclipse.gmf.runtime.sdk-feature has the wrong name in feature.properties
Summary: org.eclipse.gmf.runtime.sdk-feature has the wrong name in feature.properties
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.3   Edit
Hardware: PC Linux
: P3 major
Target Milestone: 2.3   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 12:53 EDT by Anthony Hunter CLA
Modified: 2010-07-19 21:56 EDT (History)
3 users (show)

See Also:
Ed.Merks: pmc_approved+

Attachments
Patch to fix the issue. (2.26 KB, text/plain)
2010-06-03 14:08 EDT, Anthony Hunter CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Hunter CLA 2010-06-03 12:53:46 EDT 
I just noticed that the new feature in Helios / GMF Runtime has the wrong name:

featureName=Graphical Modeling Framework Notation SDK

should have been

featureName=Graphical Modeling Framework (GMF) Runtime SDK

The notation sdk feature has:
featureName=Graphical Modeling Framework (GMF) Notation SDK
Comment 1 Anthony Hunter CLA 2010-06-03 12:55:15 EDT 
Do you think this issue is bad? I imagine it is too late to fix for Helios.
Comment 2 Kit Lo CLA 2010-06-03 13:05:39 EDT 
This is not a bad issue. But, if you can fix it in the code by Saturday (6/5), we still can correct the translations.
Comment 3 Anthony Hunter CLA 2010-06-03 14:01:27 EDT 
Hi Ed, can I get PMC approval for this?

Minor, but given we just did the GMF restructure, I do not want the Runtime SDK to have the wrong project name and create confusion.

As a result of the way Eclipse looks up the information I suppose, Help + About displays the correct information from the branding plugin, which is why I never caught this.

When you go yo the Helios update (discovery) site however, you see two notation SDK features but no Runtime SDK feature, which is what users are likely to be looking for.
Comment 4 Anthony Hunter CLA 2010-06-03 14:02:00 EDT 
Hi Ed, can I get PMC approval for this?

Minor, but given we just did the GMF restructure, I do not want the Runtime SDK
to have the wrong project name and create confusion.

As a result of the way Eclipse looks up the information I suppose, Help + About
displays the correct information from the branding plugin, which is why I never
caught this.

When you go yo the Helios update (discovery) site however, you see two notation
SDK features but no Runtime SDK feature, which is what users are likely to be
looking for.
Comment 5 Anthony Hunter CLA 2010-06-03 14:08:51 EDT 
Created attachment 170994 [details]
Patch to fix the issue.

I made the three GMF Runtime features that are found on the Helios site have the same name.
Comment 6 Anthony Hunter CLA 2010-06-03 14:21:28 EDT 
Committed to HEAD for RC4

(In reply to comment #2)
> This is not a bad issue. But, if you can fix it in the code by Saturday (6/5),
> we still can correct the translations.

I will create an Integration build for this week's IES.
Comment 7 Anthony Hunter CLA 2010-06-04 14:35:00 EDT 
The fix for this string change is in this week's GMF Runtime Build I201006041147
Comment 8 Eclipse Webmaster CLA 2010-07-16 23:38:29 EDT 
[target cleanup] 2.3 RC was the original target milestone for this
bug
Comment 9 Eclipse Webmaster CLA 2010-07-19 21:56:50 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug