Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315620 - [Progress] WorkbenchWindow is leaked
Summary: [Progress] WorkbenchWindow is leaked
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.6.1   Edit
Assignee: Dani Megert CLA
QA Contact: Prakash Rangaraj CLA
URL:
Whiteboard:
Keywords: performance
: 329711 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-03 11:58 EDT by Srimathi CLA
Modified: 2011-10-06 05:41 EDT (History)
6 users (show)

See Also:
markus.kell.r: review+

Attachments
Fix (needs to be adjusted for 3.6.1) (6.97 KB, patch)
2010-07-05 11:04 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Srimathi CLA 2010-06-03 11:58:33 EDT 
In our RCP based product we saw ProgressAnimationItem$2 instance number kept increasing. But ProgressAnimationItem was just one instance throughout the product usage. Is it a possible leak?
Probably we are not un-registering AccessibleAdapter from toolbar.
Comment 1 Dani Megert CLA 2010-07-05 09:46:57 EDT 
Same issue in the SDK (3.6 and 3.7). It looks like some service is still registered and hence holding on to the ProgressAnimationItem object via ProgressRegion and finally via WorkbenchWindow (which is also leaked).
Comment 2 Dani Megert CLA 2010-07-05 11:03:25 EDT 
There were several leaks (see patch).
Fixed in HEAD.
Comment 3 Dani Megert CLA 2010-07-05 11:04:59 EDT 
Created attachment 173440 [details]
Fix (needs to be adjusted for 3.6.1)
Comment 4 Markus Keller CLA 2010-07-06 08:22:48 EDT 
Looks good, +1 for 3.6.1.
Comment 5 Dani Megert CLA 2010-07-06 08:39:15 EDT 
Committed to R3_6_maintenance.
Comment 6 Markus Keller CLA 2010-08-03 19:03:31 EDT 
Verified in I20100802-1800 Cocoa that these leaks are fixed.
Filed bug 321658 for more problems (in Debug).
Comment 7 Dani Megert CLA 2010-08-27 04:48:48 EDT 
Verified in M20100825-0800.
Comment 8 Prakash Rangaraj CLA 2010-11-12 01:14:11 EST 
*** Bug 329711 has been marked as a duplicate of this bug. ***
Comment 9 Dani Megert CLA 2011-10-06 05:41:04 EDT 
The ui.workbench part of this fix did not make it into 4.x. Manually cherry-picked now:
Commit f2231fb6b7e17a19e71ccec75f0fceab680cab58