Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315618 - [context] common navigator working set filter changes remove focus filter on startup causing expand all for everything in the project explorer
Summary: [context] common navigator working set filter changes remove focus filter on ...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P1 blocker (vote)
Target Milestone: 3.4   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 313769 315235 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-03 11:55 EDT by Shawn Minto CLA
Modified: 2010-06-04 12:44 EDT (History)
5 users (show)

See Also:

Attachments
potential patch (5.45 KB, patch)
2010-06-03 13:59 EDT, Shawn Minto CLA 		no flags Details | Diff
mylyn/context/zip (2.28 KB, application/octet-stream)
2010-06-03 13:59 EDT, Shawn Minto CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2010-06-03 11:55:13 EDT 
It looks like there is a problem with the common navigator changes that were made with Eclipse 3.6 for the working set filter and the focus filter.  It seems that since our filters are not common filters, it will be removed when the new working set filter adds itself.  see NavigatorFitlerService#getVisibleFilters(boolean) which is called from NavigatorFitlerService#updateViewer() when the list of active filter id's changes.  Since the focus filter is not removed by the focus action, the focused viewer manager is never updated and therefore we think that it is installed and try to force a refresh and expandAll of the viewer.
Comment 1 Shawn Minto CLA 2010-06-03 13:59:23 EDT 
Created attachment 170992 [details]
potential patch

Here is a potential patch to fix this problem.  What it does is that before trying to expand the view, it ensures that the interest filter is installed if the viewer is managed by the focused viewer manager.  Steffen, lets look over this together.
Comment 2 Shawn Minto CLA 2010-06-03 13:59:24 EDT 
Created attachment 170993 [details]
mylyn/context/zip
Comment 3 Shawn Minto CLA 2010-06-03 15:03:42 EDT 
Patch committed.
Comment 4 Steffen Pingel CLA 2010-06-03 15:48:31 EDT 
*** Bug 315235 has been marked as a duplicate of this bug. ***
Comment 5 Steffen Pingel CLA 2010-06-04 02:23:53 EDT 
Thanks for fixing this Shawn! I have verified that the expand all does no longer happen. I do see though that the interest filter gets uninstalled when I switch the working set presentation which is a bug. Can you please file a separate report about that so we can look into this again in the next cycle?
Comment 6 Marc-André Laperle CLA 2010-06-04 12:44:42 EDT 
*** Bug 313769 has been marked as a duplicate of this bug. ***