Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315590 - Icon for Commit and Push are the same
Summary: Icon for Commit and Push are the same
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.9.0-M2   Edit
Assignee: Mathias Kinzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 09:55 EDT by Alex Blewitt CLA
Modified: 2010-08-04 12:22 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2010-06-03 09:55:53 EDT
Build Identifier: 0.8.1

Committing is conceptually different from pushing; the two icons shouldn't be the same. Furthermore, committing only affects your local repository, whilst pushing affects remote. Similarly, fetching comes from remote, not your own repository.

I suggest that we modify the icons for both fetch and push so that they're on the right of the database icon. That way, we distinguish them visually, and stuff-on-the-left only affects your local repo, whilst stuff-on-the-right affects remote ones. In cobbled together ASCII art, I propose doing something like:

Commit: -> ()
Push:      () ->
Fetch:     () <-



Reproducible: Always
Comment 1 Chris Aniszczyk CLA 2010-06-03 09:58:28 EDT
That's an interesting idea!

Thanks for your ongoing feedback Alex.
Comment 2 Robin Rosenberg CLA 2010-06-06 09:58:45 EDT
(In reply to comment #2)
> Build Identifier: 0.8.1
> 
> Committing is conceptually different from pushing; the two icons shouldn't be
> the same. Furthermore, committing only affects your local repository, whilst
> pushing affects remote. Similarly, fetching comes from remote, not your own
> repository.
> 
> I suggest that we modify the icons for both fetch and push so that they're on
> the right of the database icon. That way, we distinguish them visually, and
> stuff-on-the-left only affects your local repo, whilst stuff-on-the-right
> affects remote ones. In cobbled together ASCII art, I propose doing something
> like:
> 
> Commit: -> ()
> Push:      () ->
> Fetch:     () <-

This the theme of the icons in the toolbar. We can use the same icons for the team menu.
Comment 3 Mathias Kinzler CLA 2010-08-04 12:20:28 EDT
Code review: http://egit.eclipse.org/r/#change,1236
Comment 4 Chris Aniszczyk CLA 2010-08-04 12:22:00 EDT
Fixed with 7d64211cf2cb80492a9a6ee40752b7b77f78bb7a