Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315578 - Removing a repository from the Git Repositories view deletes all projects
Summary: Removing a repository from the Git Repositories view deletes all projects
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-03 09:09 EDT by Alex Blewitt CLA
Modified: 2010-06-19 10:39 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2010-06-03 09:09:56 EDT
Build Identifier: 0.8.1

When you remove a repository from the repositories view, it gives a warning message that it will delete all projects.

This seems unnecessary; even if the project is no longer shared with the Git setup (e.g. it's been disconnected), there's no reason to remove the project just because the repository is no longer listed in the repositories project.

Creating a new project and sharing (or importing an existing project and sharing) results in a project with no reference in the 'git repositories' view, and appears to have no negative effect on use.

Finally, the project isn't really 'deleted' as such - it's just removed from the workspace. The bits are still on disk. 

It should really be replaced with a 'Do you want to remove these projects from the workspace?' dialog, and permit both removal and non-removal of the projects.

Reproducible: Always
Comment 1 Alex Blewitt CLA 2010-06-03 09:30:53 EDT
The 'all projects' is really 'all projects sharing that same repository', by the way. It won't delete non-Git projects or Git projects on different repositories.
Comment 2 Mathias Kinzler CLA 2010-06-07 03:29:16 EDT
Good point. I'll try to replace this with a "do you want to remove these projects from the workspace" dialog.
Comment 3 Mathias Kinzler CLA 2010-06-18 10:23:44 EDT
Code review at
http://egit.eclipse.org/r/#change,895
Comment 4 Matthias Sohn CLA 2010-06-19 10:39:45 EDT
merged as 47f1635b58cfce81ad407e76093a572ace32b37f