Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315529 - Backport [terminal] Terminal always jumps to line 1 if ScrollLock is activated
Summary: Backport [terminal] Terminal always jumps to line 1 if ScrollLock is activated
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.2+   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 205486 294468
Blocks:
  Show dependency tree
 
Reported: 2010-06-03 00:05 EDT by Martin Oberhuber CLA
Modified: 2010-06-03 04:47 EDT (History)
4 users (show)

See Also:
uwe.st: review+

Attachments
Patch including all changes and version updates (39.46 KB, patch)
2010-06-03 00:34 EDT, Martin Oberhuber CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-06-03 00:05:52 EDT 
+++ This bug was initially created as a clone of Bug #205486 +++

In our commercial product on top of Eclipse, we have activated the TerminalActionScrollLock in a custom view embedding the Terminal widget. Unfortunately, it turns out that the Terminal always jumps to line 1 of the output when scroll lock is chosen.

The patch in attachment 170909 [details] on bug 205486 resolves that issue.
Comment 1 Martin Oberhuber CLA 2010-06-03 00:30:58 EDT 
It turns out that it's impossible to backport the fix for bug 205486 without also backporting the fix for bug 294468. Essentially, we synchronize the 3.1.2+ Terminal widget with the 3.2 version.
Comment 2 Martin Oberhuber CLA 2010-06-03 00:34:01 EDT 
Created attachment 170910 [details]
Patch including all changes and version updates

Attached patch includes all changes and version updates. Unfortunately, due to the feature inclusion structure, features upto rse.sdk are affected.

Affected plugins:
-----------------
org.eclipse.tm.terminal

Affected features:
------------------
org.eclipse.tm.terminal
org.eclipse.tm.terminal.sdk
org.eclipse.rse.terminals
org.eclipse.rse
org.eclipse.rse.sdk
Comment 3 Martin Oberhuber CLA 2010-06-03 00:35:14 EDT 
Hi Uwe, our policy has it that backports for a maintenance stream require a single additional committer's review. Please give you review+ so I can proceed checking in the changes and having a J-build created.
Comment 4 Martin Oberhuber CLA 2010-06-03 04:47:48 EDT 
Released, please verify with J20100603-0600 (will be available around 1300 CEST)