Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315494 - [api] add validateSetttings button (fallback) to AbstractRepositorySettingsPage
Summary: [api] add validateSetttings button (fallback) to AbstractRepositorySettingsPage
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 16:32 EDT by Thomas Ehrnhoefer CLA
Modified: 2011-01-13 23:31 EST (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (25.59 KB, application/octet-stream)
2010-10-18 19:53 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2010-06-02 16:32:28 EDT 
In case the settings page is used in a different wizard (where one has no control over, e.g. the platform's import wizard), there will be no ValidateSettings button (since it is in the wizard itself).

The settings page should check with it's wizard if there is actually such a validation control, and if not, display it on the page.
Comment 1 Steffen Pingel CLA 2010-07-22 20:16:58 EDT 
That makes sense. I'll tentatively schedule this for 3.5 so we can consider it for the common repository UI that is part of the Team Repositories view and possibly the task repository settings page.
Comment 2 Steffen Pingel CLA 2010-10-18 19:53:21 EDT 
Added new method AbstractRepositorySettingsPage.createValidationControls() which adds a validation control unless the page is embedded in a TaskRepositoryWizardDialog.
Comment 3 Steffen Pingel CLA 2010-10-18 19:53:22 EDT 
Created attachment 181140 [details]
mylyn/context/zip
Comment 4 Thomas Ehrnhoefer CLA 2010-10-19 10:55:47 EDT 
Thanks Steffen