Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315483 - [NLS] Most hyperlinks show as 'Unknown Hyperlink'
Summary: [NLS] Most hyperlinks show as 'Unknown Hyperlink'
Status: RESOLVED WONTFIX
Alias: None
Product: JSDT
Classification: WebTools
Component: Web (show other bugs)
Version: 3.0.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on: 272106
Blocks:
  Show dependency tree
 
Reported: 2010-06-02 16:12 EDT by Nitin Dahyabhai CLA
Modified: 2010-09-29 18:08 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2010-06-02 16:12:30 EDT 
+++ This bug was initially created as a clone of Bug #272106 +++

Created an attachment (id=131729)
proposed patch

None of the hyperlink implementations in source editing implement getHyperlinkText() improperly.  Some of them display strings without verbs, such as the full path to a file when that's what would open, but most don't return any text at all and show up in the hyperlink list as 'Unknown Hyperlink', which is an especially bad problem when multiple hyperlinks are available in the same location.  The attached patch adds 3 strings to source editing to generically represent "Open {0}" and sets up the hyperlink implementations to bind better strings to it.
Comment 1 Chris Jaun CLA 2010-08-31 09:52:29 EDT 
Nitin, what is the status of this?

Is this something we still need to get into 3.0.5p?
Comment 2 Nitin Dahyabhai CLA 2010-09-29 18:08:40 EDT 
Would need new strings.