Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315434 - File menus and keyboard shortcuts are always enabled in the Datapool editor.
Summary: File menus and keyboard shortcuts are always enabled in the Datapool editor.
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Bozier jerome CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: closed472
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 13:35 EDT by Ben Chen CLA
Modified: 2016-05-05 11:02 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Chen CLA 2010-06-02 13:35:54 EDT
Build Identifier: TPTP-4.7.0RC3-201006011014

Related to:
Bugzilla_243366_2 under
Test.UI.EncryptedDatapool_editing

While a encrypted cell or record is on focus, the cut/copy option is disabled from right click context menu, however, the user can use keyboard shortcut CTRL+C/X or select the options from file menu to perform such actions. Note that the value copied would be corrupted as well.

Reproducible: Always
Comment 1 Ben Chen CLA 2010-06-02 13:38:20 EDT
Hi Kathy:
since the 3 most recent test report indicates that this test case passed, it could be a regression.
Comment 2 Kathy Chan CLA 2010-06-03 15:17:27 EDT
Jerome,

Please take a look and assess if this is a regression or not.
Comment 3 Bozier jerome CLA 2010-06-04 08:23:46 EDT
checking what it happening

can take some time since Paul is the datapool specialist and i never put my fingers in this code....
Comment 4 Bozier jerome CLA 2010-06-04 08:42:01 EDT
ok, i found where code around this is + the manual test

cut/copy are expected to be disabled when variable is encrypted
(check Test.UI.EncryptedDatapool_editing / Bugzilla_243366_2)
after some testing, they are really disabled as expected

test case does not talk about shortcut use (CTRL-C/X) so it seems that it never have been tested (it explain why result was green on the 3 previous launch)

to make short, it is not a regression, it is a new bug that is not covered by the existing test case
Comment 5 Paul Slauenwhite CLA 2010-06-22 10:09:02 EDT
(In reply to comment #4)
> ok, i found where code around this is + the manual test
> 
> cut/copy are expected to be disabled when variable is encrypted
> (check Test.UI.EncryptedDatapool_editing / Bugzilla_243366_2)
> after some testing, they are really disabled as expected
> 
> test case does not talk about shortcut use (CTRL-C/X) so it seems that it never
> have been tested (it explain why result was green on the 3 previous launch)
> 
> to make short, it is not a regression, it is a new bug that is not covered by
> the existing test case

Requires the existing test case to be update to cover the file menus and keyboard shortcuts.
Comment 6 Paul Slauenwhite CLA 2010-06-22 13:56:47 EDT
Of interested but not formally requested by a consuming product.  As such, a candidate defect for TPTP 4.7.0.1.
Comment 7 Paul Slauenwhite CLA 2010-06-22 14:08:14 EDT
In fact, this symptom extends to the Select All, Delete, and Find/Replace file menus and keyboard shortcuts.  The problem is that the menus are only enabled when the context menu is about to appear and not when the selection changes in the datapool table.
Comment 8 Paul Slauenwhite CLA 2010-06-23 08:43:45 EDT
After a closer inspection, the actions (e.g. org.eclipse.hyades.test.ui.datapool.internal.action.CopyAction) are disabled correctly, but not respected by the action handlers for the the file
menus and keyboard shortcuts.  As such, we would have to overhaul org.eclipse.hyades.ui.internal.editor.action.ActionHandlerListener and org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolActionHandlerListener.  Given that our consuming products are not requesting this change and invoking the actions do not corrupt the datapool or expose unencrypted data, we will defer this defect.
Comment 9 Paul Slauenwhite CLA 2010-11-26 07:28:29 EST
Insufficient resources to complete.
Comment 10 Kathy Chan CLA 2011-02-11 13:39:58 EST
This defect had been resolved as WONTFIX for more than 1 month.  Closing this on the reporter's behalf.  Please re-open if you have further comment on this issue.
Comment 11 Kathy Chan CLA 2011-02-11 14:51:18 EST
Closed in TPTP 4.7.2.