Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315414 - Need to add a class to eclipse.org-common
Summary: Need to add a class to eclipse.org-common
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Website (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: phoenix.ui CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 11:34 EDT by Eclipse Webmaster CLA
Modified: 2010-06-17 13:28 EDT (History)
2 users (show)

See Also:

Attachments
New membership class (deleted)
2010-06-02 11:50 EDT, Eclipse Webmaster CLA 		no flags Details
New management class v2 (3.39 KB, text/plain)
2010-06-02 15:27 EDT, Eclipse Webmaster CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eclipse Webmaster CLA 2010-06-02 11:34:25 EDT 
As part of solving bug 231891 I've created a class to handle the magic of getting the image details out of the DB, and inserting the correct values if it can.

This should probably go in classes/membership.

-M.
Comment 1 Eclipse Webmaster CLA 2010-06-02 11:50:20 EDT 
Created attachment 170822 [details]
New membership class
Comment 2 Wayne Beaton CLA 2010-06-02 13:12:16 EDT 
+1
Comment 3 Nathan Gervais CLA 2010-06-02 14:02:12 EDT 
+1 Looks Good Matt
Comment 4 Denis Roy CLA 2010-06-02 14:17:21 EDT 
A couple of things:

1. I'd update the copyright header

2. I'd sanitize $_size in your function to avoid SQL injection.  Actually, I believe App has a sqlSanitize function which is a great catch-all.
Comment 5 Eclipse Webmaster CLA 2010-06-02 15:26:41 EDT 
The content of attachment 170822 [details] has been deleted by
    Eclipse Webmaster <webmaster@eclipse.org>
who provided the following reason:

obsolete

The token used to delete this attachment was generated at 2010-06-02 15:26:32 EDT.
Comment 6 Eclipse Webmaster CLA 2010-06-02 15:27:41 EDT 
Created attachment 170868 [details]
New management class v2

Ok, I've added the sanitize and updated the copyright notice.

-M.
Comment 7 Denis Roy CLA 2010-06-02 16:15:06 EDT 
+1
Comment 8 Denis Roy CLA 2010-06-17 11:23:44 EDT 
Just doing some triage -- was this committed?
Comment 9 Eclipse Webmaster CLA 2010-06-17 13:28:11 EDT 
Yes.

-M.