Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315397 - Column of GridCellRenderer not set in Grid.onPaint(PaintEvent)
Summary: Column of GridCellRenderer not set in Grid.onPaint(PaintEvent)
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Nebula (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 10:12 EDT by Thomas Halm CLA
Modified: 2021-07-05 11:39 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch for org.eclipse.nebula.widgets.grid.Grid (952 bytes, patch)
2010-06-02 10:46 EDT, Thomas Halm CLA 		no flags Details | Diff
Proposed patch with new fixes (2.26 KB, text/plain)
2010-06-03 09:10 EDT, Thomas Halm CLA 		no flags Details
Proposed patch with new fixes (2.83 KB, patch)
2010-06-03 09:30 EDT, Thomas Halm CLA 		tom.schindl: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Halm CLA 2010-06-02 10:12:03 EDT 
Build Identifier: M20100211-1343

When the onPaint() method delegate the rendering of the cell to the cellRenderer of the current column, the column index is not propagated to the cell renderer.

In my opinion the call "column.getCellRenderer().setColumn(indexOf(column))" is missing around line 5496 in Class org.eclipse.nebula.widgets.grid.Grid.

I have implemented a GridCellRenderer, but with this bug I'm not able to get the right "column context" inside the paint(GC,Object) method.



Reproducible: Always
Comment 1 Thomas Schindl CLA 2010-06-02 10:14:36 EDT 
If you attach a patch I can apply it ASAP
Comment 2 Thomas Halm CLA 2010-06-02 10:46:10 EDT 
Created attachment 170809 [details]
Proposed patch for org.eclipse.nebula.widgets.grid.Grid
Comment 3 Thomas Halm CLA 2010-06-03 09:10:47 EDT 
Created attachment 170948 [details]
Proposed patch with new fixes

I found two more calls to getCellRenderer() where the column index was not propagated. 

Changes in: 
      Grid.onPaint() -> old 
      Grid.computeItemHeight() -> new
GridColumn.pack() -> new
Comment 4 Thomas Schindl CLA 2010-06-03 09:15:43 EDT 
Looks good, one minor thing - I think we should store the content of indexOf(column) call in an local variable
Comment 5 Thomas Halm CLA 2010-06-03 09:30:43 EDT 
Created attachment 170951 [details]
Proposed patch with new fixes

Ok, there was already a local variable with the index of the column. I replaced the method calls in the new patch.
Comment 6 Thomas Schindl CLA 2010-06-08 02:05:06 EDT 
Applied patch with attribution to CVS-HEAD