Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315393 - change remote project wizard to setup service model earlier
Summary: change remote project wizard to setup service model earlier
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.0   Edit
Assignee: Chris Recoskie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 09:33 EDT by Chris Recoskie CLA
Modified: 2010-06-03 14:30 EDT (History)
0 users

See Also:
g.watson: review+


Attachments
propsed patch (5.33 KB, patch)
2010-06-02 09:34 EDT, Chris Recoskie CLA
recoskie: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Recoskie CLA 2010-06-02 09:33:39 EDT
Currently, the remote project wizard uses org.eclipse.ptp.rdt.ui.wizards.ServiceModelWizardPageOperation to create the service model for the project.  This runs after the project has been created.

The problem with this is that when the CDT project is created, it will want to run the scanner discovery mechanism, which in the case of a remote project, requires a remote build.  As you can imagine, this requires having a service model for the project.

The proposed patch moves the service model creation to the point right after the IProject handle is created.  This way the service model is available when CDT is creating the project.
Comment 1 Chris Recoskie CLA 2010-06-02 09:34:49 EDT
Created attachment 170798 [details]
propsed patch

Proposed patch attached.
Comment 2 Greg Watson CLA 2010-06-02 14:52:42 EDT
I saw some errors "Error updating discovered info", "Updating discovered includes and macros" when a managed project, but I think that happened before. Also, there's a problem going back from the service configuration page. 

Otherwise I don't see any difference.
Comment 3 Chris Recoskie CLA 2010-06-02 19:18:33 EDT
(In reply to comment #2)
> I saw some errors "Error updating discovered info", "Updating discovered
> includes and macros" when a managed project, but I think that happened before.
> Also, there's a problem going back from the service configuration page. 
> Otherwise I don't see any difference.

Those errors were already there AFAIK.

Scanner discovery is a bit spotty right now till I get some XLC toolchain fixes in.
Comment 4 Chris Recoskie CLA 2010-06-03 14:30:33 EDT
Applied to HEAD.