Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315389 - [Preferences] 'Defaults' button does nothing in 'Comment Templates' preference page
Summary: [Preferences] 'Defaults' button does nothing in 'Comment Templates' preferenc...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P4 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 08:44 EDT by Remy Suen CLA
Modified: 2011-01-26 04:21 EST (History)
2 users (show)

See Also:
tomasz.zarna: review+

Attachments
Patch: cleaning the list (1.48 KB, patch)
2010-12-23 06:09 EST, Malgorzata Janczarska CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-06-02 08:44:30 EDT 
'Apply' is useful for applying changes and then moving to another page but the 'Defaults' button doesn't seem to do anything. It should either wipe all the templates (probably not a good idea) or the button should be disabled.
Comment 1 Szymon Brandys CLA 2010-12-21 21:21:26 EST 
(In reply to comment #0)
> 'Apply' is useful for applying changes and then moving to another page but the
> 'Defaults' button doesn't seem to do anything. It should either wipe all the
> templates (probably not a good idea) or the button should be disabled.

Some property pages don't have this button. I couldn't find a page with disabled 'Restore Defaults' though. Anyway I don't think it is a bad idea to just clean the list on 'Restore Defaults'.
Comment 2 Tomasz Zarna CLA 2010-12-22 05:47:15 EST 
(In reply to comment #0)
> It should [...] wipe all the templates 

This is what other preference pages with templates do (e.g. Java Editor, Ant Editor). I think we should stand in line and do the same thing - agreeing with Szymon.
Comment 3 Malgorzata Janczarska CLA 2010-12-23 06:09:31 EST 
Created attachment 185759 [details]
Patch: cleaning the list

Patch I've attached cleans the list of comments.
Comment 4 Tomasz Zarna CLA 2010-12-23 07:11:01 EST 
The patch is good. Applied to HEAD after updating the copyrights section. Available in builds >=N20101223-2000.