Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315384 - Improve dialog that warns about binary files when creating a patch
Summary: Improve dialog that warns about binary files when creating a patch
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-02 08:28 EDT by Dani Megert CLA
Modified: 2010-06-10 01:52 EDT (History)
1 user (show)

See Also:

Attachments
Current dialog (7.84 KB, image/png)
2010-06-02 08:30 EDT, Dani Megert CLA 		no flags Details
Fix (4.18 KB, patch)
2010-06-02 08:31 EDT, Dani Megert CLA 		no flags Details | Diff
Dialog with Fix applied (8.27 KB, image/png)
2010-06-02 08:31 EDT, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-06-02 08:28:45 EDT 
3.6.

Improve dialog that warns about binary files when creating a patch.

The dialog should be a warning dialog and the wording should be improved.
Comment 1 Dani Megert CLA 2010-06-02 08:29:01 EDT 
I'll take that bug.
Comment 2 Dani Megert CLA 2010-06-02 08:30:52 EDT 
Created attachment 170783 [details]
Current dialog
Comment 3 Dani Megert CLA 2010-06-02 08:31:16 EDT 
Created attachment 170785 [details]
Fix
Comment 4 Dani Megert CLA 2010-06-02 08:31:38 EDT 
Created attachment 170787 [details]
Dialog with Fix applied
Comment 5 Dani Megert CLA 2010-06-09 12:40:56 EDT 
Fixed in HEAD.