Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315317 - aggregator does not copy download.stats property from contributed artifacts
Summary: aggregator does not copy download.stats property from contributed artifacts
Status: RESOLVED FIXED
Alias: None
Product: CBI
Classification: Technology
Component: CBI p2 Repository Aggregator (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 17:55 EDT by David Williams CLA
Modified: 2016-09-16 15:59 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2010-06-01 17:55:17 EDT 
/releases/staging has a recent build. 

I've never seen download.stats property in our aggregate's artifacts.jar/xml file. 

With webtools RC3, I've added them in webtools contribution, so fairly sure it was "done right". In webtools, the following is an example of a feature marked with "download.stats". 

<artifact classifier='org.eclipse.update.feature' id='org.eclipse.wst.web_ui.feature' version='3.2.0.v201005241510-7O7CFb3EMf84nOyJKuT05LU72RId'>
  <processing size='1'>
    <step id='org.eclipse.equinox.p2.processing.Pack200Unpacker' required='true'/>
  </processing>
  <properties size='5'>
    <property name='artifact.size' value='14631'/>
    <property name='download.size' value='14631'/>
    <property name='format' value='packed'/>
    <property name='download.stats' value='org.eclipse.wst.web.ui.feature_helios_sr0'/>
    <property name='download.md5' value='28297ea3a88d09ae6eb05e9bf85ba2d9'/>
  </properties>
</artifact>


Now that I look at it, it appears the artifacts metadata is missing quite a bit. it only has 

 <artifact classifier='org.eclipse.update.feature' id='org.eclipse.wst.web_ui.feature' version='3.2.0.v201005241510-7O7CFb3EMf84nOyJKuT05LU72RId'>
     <properties size='1'>
       <property name='download.size' value='17747'/>
     </properties>
   </artifact>

No checksums?
Comment 1 Thomas Hallgren CLA 2010-06-01 20:29:09 EDT 
Artifact properties are now copied correctly. In case of unpack as sibling, the properties from the packed artifact are used. Except the download.size, download.md5, and format. Those are re-generated.

The fix is released to trunk, revision 1046 and a new build of the b3.aggregator has commenced.
Comment 2 David Williams CLA 2010-06-02 00:45:24 EDT 
looks fixed to me. New artifacts.jar/xml in 

http://download.eclipse.org/releases/staging/

Thanks so much for the quick turn around. 

(Note, I'm not marking as 'fixed' assuming that's up to you ... in case you wanted to check something, or review ... once you wake up :)
Comment 3 Thomas Hallgren CLA 2010-06-02 09:13:30 EDT 
.
Comment 4 David Williams CLA 2016-09-16 15:59:23 EDT 
[Bookkeeping change only. Moving bugs to the new "home" of aggregator, CBI.
No change to assignee for resolved and verified bugs.]