Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315307 - [LTTng, TMF] Ensure all strings are externalized
Summary: [LTTng, TMF] Ensure all strings are externalized
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 17:15 EDT by Andrew Overholt CLA
Modified: 2022-01-13 14:53 EST (History)
0 users

See Also:

Attachments
Part 1 (339.15 KB, patch)
2010-11-09 10:33 EST, Francois Chouinard CLA 		fchouinard: iplog-
Details | Diff
Part 2 (91.04 KB, patch)
2010-11-10 10:26 EST, Francois Chouinard CLA 		fchouinard: iplog-
Details | Diff
Part 3 (94.13 KB, patch)
2010-11-19 19:05 EST, Francois Chouinard CLA 		fchouinard: iplog-
Details | Diff
Part 4 (158.90 KB, patch)
2010-11-21 14:27 EST, Francois Chouinard CLA 		fchouinard: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2010-06-01 17:15:34 EDT 
While testing bug #313161, I noticed that some strings (notably the table headers in the Events and Statistics views and the labels in the Histogram view) aren't externalized.
Comment 1 Francois Chouinard CLA 2010-06-09 01:07:51 EDT 
Postponed to 0.6.1
Comment 2 Francois Chouinard CLA 2010-11-09 10:33:11 EST 
Created attachment 182728 [details]
Part 1

This is the first contribution to this bug.

After "warnifying" the compiler's "Non-externalized strings" code style, ~4000 warnings popped-up :-(

This patch doesn't address the main issue but clears up a large number of warnings by adding @SuppressWarning annotations to cover the following cases:

- all test code
- all tracing code
- all toString() methods
- all exception messages (they will be re-visited anyway)
- all punctuation strings (this might not be that kosher...)
- all internal constants (Eclipse IDs, default file names, paths, ...)
Comment 3 Francois Chouinard CLA 2010-11-10 10:26:25 EST 
Created attachment 182818 [details]
Part 2

Second round of fixes.
Comment 4 Francois Chouinard CLA 2010-11-19 19:05:59 EST 
Created attachment 183509 [details]
Part 3
Comment 5 Francois Chouinard CLA 2010-11-21 14:27:14 EST 
Created attachment 183540 [details]
Part 4

Final part.
Comment 6 Francois Chouinard CLA 2010-11-22 10:10:43 EST 
Comment on attachment 183540 [details]
Part 4

Patch committed on Indigo
Comment 7 Francois Chouinard CLA 2010-11-22 10:15:04 EST 
All strings are now either externalized or tagged with $NON-NLS$. The only "UI" strings that are not extracted in the various messages.properties files are for the exceptions.
Comment 8 Francois Chouinard CLA 2011-07-22 14:34:22 EDT 
Delivered with 0.7