Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315304 - Externalize "Rpmlint" string
Summary: Externalize "Rpmlint" string
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: RPM (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 17:07 EDT by Andrew Overholt CLA
Modified: 2010-06-08 13:26 EDT (History)
1 user (show)

See Also:

Attachments
proposed patch (4.11 KB, patch)
2010-06-04 16:13 EDT, Andrew Overholt CLA 		overholt: review?
Details | Diff
mylyn/context/zip (1.22 KB, application/octet-stream)
2010-06-04 16:13 EDT, Andrew Overholt CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2010-06-01 17:07:36 EDT 
While verifying bug #313161, I came across a string that wasn't externalized.  I'll attach a stab at a patch.
Comment 1 Andrew Overholt CLA 2010-06-01 17:11:21 EDT 
Actually, there are a bunch of strings in org.eclipse.linuxtools.rpm.rpmlint that need to be externalized.  Please do so :)
Comment 2 Andrew Overholt CLA 2010-06-01 17:14:15 EDT 
There are also some in the specfile editor (especially the preferences) and stubby.
Comment 3 Andrew Overholt CLA 2010-06-04 16:13:21 EDT 
Created attachment 171167 [details]
proposed patch

Here's a potential patch that externalizes the items in plugin.xml.
Comment 4 Andrew Overholt CLA 2010-06-04 16:13:22 EDT 
Created attachment 171168 [details]
mylyn/context/zip
Comment 5 Andrew Overholt CLA 2010-06-04 16:14:01 EDT 
Comment on attachment 171167 [details]
proposed patch

Alex, please review this patch and commit if you're satisfied.  Thanks.
Comment 6 Alexander Kurtakov CLA 2010-06-07 10:24:02 EDT 
Thanks committed in r24973.
Comment 7 Andrew Overholt CLA 2010-06-07 14:29:45 EDT 
We need to await tonight's Babel build to be able to verify this.
Comment 8 Andrew Overholt CLA 2010-06-07 14:34:27 EDT 
Reopening to verify tomorrow.
Comment 9 Roland Grunberg CLA 2010-06-08 11:46:05 EDT 
Haven't been able to verify on Babel build yet due to http://dev.eclipse.org/mhonarc/lists/babel-dev/msg00887.html, but I can see that the externalized strings are properly replaced and used in the Manifest file.
Comment 10 Andrew Overholt CLA 2010-06-08 13:26:48 EDT 
I'm satisfied with that analysis and don't want to be held up by the Babel situation so let's close this.  Thanks.