Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315303 - Externalize "SystemTap" preferences category string
Summary: Externalize "SystemTap" preferences category string
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Systemtap (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6   Edit
Assignee: anithra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 17:07 EDT by Andrew Overholt CLA
Modified: 2011-06-06 15:29 EDT (History)
3 users (show)

See Also:

Attachments
Patch (543 bytes, patch)
2010-06-08 13:44 EDT, Roland Grunberg CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2010-06-01 17:07:14 EDT 
While verifying bug #313161, I came across a string that wasn't externalized.  I'll attach a stab at a patch.
Comment 1 Andrew Overholt CLA 2010-06-01 17:09:27 EDT 
Actually, I see a few strings in the various SystemTap plugin.xml files.  Please externalize them.
Comment 2 Andrew Overholt CLA 2010-06-04 17:28:44 EDT 
It looks like this was already done.  I can see it externalized as of revision 23786 but with the latest Babel build (20100604-0400) it isn't externalized.  Anyone have any ideas?
Comment 3 Andrew Overholt CLA 2010-06-08 10:50:36 EDT 
Roland, do you have any ideas here?
Comment 4 Roland Grunberg CLA 2010-06-08 13:44:02 EDT 
Created attachment 171434 [details]
Patch

This should fix the issue.
Comment 5 Andrew Overholt CLA 2010-06-08 13:45:52 EDT 
Nice catch, Roland.  +1 to the fix.
Comment 6 Roland Grunberg CLA 2010-06-08 13:53:55 EDT 
Revision 24983.
Comment 7 Andrew Overholt CLA 2010-06-08 14:55:37 EDT 
I know we won't be able to verify with Babel right now, but can you see if things are externalized as you expect, Roland?  Thanks.

https://build.eclipse.org/hudson/job/cbi-linuxtools-Helios/235/
Comment 8 Roland Grunberg CLA 2010-06-08 15:28:38 EDT 
The string 'SystemTap' is externalized as expected.
Comment 9 Andrew Overholt CLA 2010-06-08 15:38:36 EDT 
Thanks, Roland.
Comment 10 Andrew Overholt CLA 2011-06-06 15:29:37 EDT 
Comment on attachment 171434 [details]
Patch

Marking patch obsolete since it was done by a committer.