Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315289 - Run on server wizard overwrites server/module validation message
Summary: Run on server wizard overwrites server/module validation message
Status: NEW
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 major with 1 vote (vote)
Target Milestone: Future   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard: plan_draft_325
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 16:06 EDT by Konstantin Komissarchik CLA
Modified: 2016-11-02 11:02 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2010-06-01 16:06:35 EDT 
There appears to be a regression in the Run on Server wizard in Helios where validation performed by a runtime to determine whether a project/module is compatible with it gets overwritten and user gets no feedback for why the wizard cannot be completed (no error message at all).

The base scenario is roughly as follows... Say you have two versions of a runtime v1 and v2. Instances of both are defined in the workspace. You then have a project that targets v2 and has facets that are incompatible with v1. Now invoke Run on Server on an artifact in the project. Select v2 (everything is ok). Select v1, no validation and next/finish is disabled.

I have traced this down to a logic fault in NewManualServerComposite.handleTypeSelection method. Around line 647, the validation message gets set correctly. A little further in that method on line 685, checkHostAndServerType method is called. In the body of that method, a different validation check is performed and if that check is ok, the message is unset.
Comment 1 Konstantin Komissarchik CLA 2010-06-01 16:08:40 EDT 
Would be great if this was addressed in 3.2.1.
Comment 2 Andras Kerekes CLA 2016-11-02 11:02:52 EDT 
If the user modifies the host name, the validation error message will be shown correctly.