Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315263 - ChangeLog plugin isn't adding in C function name for change
Summary: ChangeLog plugin isn't adding in C function name for change
Status: CLOSED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: ChangeLog (show other bugs)
Version: 0.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.6   Edit
Assignee: Jeff Johnston CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 13:45 EDT by Jeff Johnston CLA
Modified: 2010-06-02 14:33 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Johnston CLA 2010-06-01 13:45:41 EDT 
If a C function is altered for a checked out C project and Prepare ChangeLog is selected, the function name is not being added to the entry.
Comment 1 Jeff Johnston CLA 2010-06-01 14:37:34 EDT 
Deprecated method used to get AST was failing.  Code has been changed to use non-deprecated method and newer way to get AST.
Comment 2 Andrew Overholt CLA 2010-06-02 13:05:38 EDT 
I'm now seeing NPEs when attempting to add a ChangeLog entry:

java.lang.NullPointerException
        at org.eclipse.linuxtools.changelog.core.actions.InsertChangeLogKeyHandler.getChangelog(InsertChangeLogKeyHandler.java:60)
        at org.eclipse.linuxtools.changelog.core.actions.InsertChangeLogKeyHandler.execute(InsertChangeLogKeyHandler.java:149)
        at org.eclipse.linuxtools.changelog.core.actions.InsertChangeLogKeyHandler.run(InsertChangeLogKeyHandler.java:191)
        at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
        at org.eclipse.ui.internal.WWinPluginAction.runWithEvent(WWinPluginAction.java:229)
        at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
        at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
        at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1234)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3159)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
        at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:616)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1383)
Comment 3 Jeff Johnston CLA 2010-06-02 14:06:47 EDT 
I believe you are seeing a separate problem.  I have trunk checked out and it is working fine though I found a new error when trying to create a changelog entry for an external C file.  The code in question according to the traceback:


	IEditorPart getChangelog() {

		IConfigurationElement formatterConfigElement = extensionManager
				.getFormatterConfigElement();


has nothing to do with the change made to fix this bug which has to do with guessing the function name for C/C++ code.

Can you elaborate on your problem scenario?
Comment 4 Jeff Johnston CLA 2010-06-02 14:33:20 EDT 
Closing again since you have it working now.