Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 315256 - [CSS] Remember Active ThemeId as Preference
Summary: [CSS] Remember Active ThemeId as Preference
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-01 13:16 EDT by Thomas Schindl CLA
Modified: 2010-06-15 02:51 EDT (History)
4 users (show)

See Also:

Attachments
Patch (5.59 KB, patch)
2010-06-01 13:16 EDT, Thomas Schindl CLA 		no flags Details | Diff
patch (4.86 KB, patch)
2010-06-11 11:51 EDT, Thomas Schindl CLA 		no flags Details | Diff
Update for 4.0 SDK (589 bytes, patch)
2010-06-12 10:25 EDT, Thomas Schindl CLA 		no flags Details | Diff
Update for 4.0 SDK (1.11 KB, patch)
2010-06-12 10:59 EDT, Thomas Schindl CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-06-01 13:16:51 EDT 
Created attachment 170665 [details]
Patch

If the user switches the theme actively we should remember this setting and discard the branding parameter.
Comment 1 Thomas Schindl CLA 2010-06-01 13:18:32 EDT 
Boris, Bodgan do you think the preference should be part of the theme-bundle or better part of ui.workbench.swt?
Comment 2 Thomas Schindl CLA 2010-06-11 11:51:14 EDT 
Created attachment 171741 [details]
patch

This patch introduces the new cssTheme-Parameter to use for themes but supports the old applicationCSS until all customers switched to this new style.

The preference is read out and used instead of the plugin.xml value. If we are ok with this patch then I'll release it and send out a mail to e4-dev
Comment 3 Thomas Schindl CLA 2010-06-11 12:04:17 EDT 
I've released the patch from above so that it gets into the build
Comment 4 Thomas Schindl CLA 2010-06-12 10:25:14 EDT 
Created attachment 171784 [details]
Update for 4.0 SDK
Comment 5 Thomas Schindl CLA 2010-06-12 10:27:07 EDT 
John or Paul, I think you've got commit rights on org.eclipse.platform. Can you apply the patch "Update for 4.0 SDK" please.
Comment 6 Thomas Schindl CLA 2010-06-12 10:59:14 EDT 
Created attachment 171785 [details]
Update for 4.0 SDK
Comment 7 Thomas Schindl CLA 2010-06-12 12:25:36 EDT 
Just for information. I've now reactivated applicationCSS-switch which makes sense for very small RCP-Application where setup up our Themeing stuff is overkill (e.g. our photo-Demo is not using our Themeing stuff).

Beside that I've extended the Extension Point to allow people to contribute OSGIResource Lookup URIs
Comment 8 Paul Webster CLA 2010-06-14 18:34:54 EDT 
(In reply to comment #6)
> Created an attachment (id=171785) [details]
> Update for 4.0 SDK

Released for tonight's build.

PW
Comment 9 Thomas Schindl CLA 2010-06-15 02:51:30 EDT 
now that the changes to SDK are released marking as fixed